fix(mode): update .env atomically via mv -f in mode-switch.sh - #2767
Open
vaibhavsrv wants to merge 1 commit into
Open
fix(mode): update .env atomically via mv -f in mode-switch.sh#2767vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
vaibhavsrv
force-pushed
the
fix/mode-switch-atomic-env-update
branch
from
August 30, 2026 08:05
0e93c59 to
ffe899d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/mode-switch.sh,env_set()updates.envvalues by redirectingawkoutput to"${ENV_FILE}.tmp"and overwriting$ENV_FILEviacat "${ENV_FILE}.tmp" > "$ENV_FILE". Overwriting directly via redirection is non-atomic and risks zero-byte truncation if process execution is interrupted.Fix
Replace
cat ... > ... && rm -f ...with a direct atomicmv -f "${ENV_FILE}.tmp" "$ENV_FILE"operation inmode-switch.sh.Verification
Ran
bash -n ods/scripts/mode-switch.sh(passed cleanly).git diff --checkpassed cleanly.