test(scripts): add coverage for check-release-claims.sh - #3187
Open
Hoang130203 wants to merge 1 commit into
Open
test(scripts): add coverage for check-release-claims.sh#3187Hoang130203 wants to merge 1 commit into
Hoang130203 wants to merge 1 commit into
Conversation
check-release-claims.sh cross-checks manifest.json's OS support flags against docs/SUPPORT-MATRIX.md and docs/PLATFORM-TRUTH-TABLE.md wording, but had no test. Covers the real repo passing end-to-end, missing manifest/docs, each manifest support-flag violation, each missing doc claim, and a fully consistent pass.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-release-claims.shcross-checksmanifest.json's OS support flags againstdocs/SUPPORT-MATRIX.mdanddocs/PLATFORM-TRUTH-TABLE.mdwording claims, but had no test — unlikecheck-compatibility.shandcheck-version-consistency.py, which now have coverage.tests/test-check-release-claims.sh, following the sandboxed-script-copy pattern used bytests/test-check-compatibility.sh.Test plan
bash -n tests/test-check-release-claims.shpassesjq -r '<path>' <file>queries this script uses (nojqbinary available in this sandbox) — 9/9 passedjq(same requirement ascheck-release-claims.shitself)