fix(update): iterate old backups safely when names have spaces - #3247
Open
patil2001 wants to merge 1 commit into
Open
fix(update): iterate old backups safely when names have spaces#3247patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
Word-splitting the find output defeated retention pruning for any backup dir containing a space.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for dir in $backup_dirsword-splits the find output, so a backup directory with a space in its name gets split and the retention prune (rm -rf "$dir") never removes the intended backup.Read the find output line-by-line into the loop instead.