fix(windows): replace stale Hermes SOUL.md instead of guarding on Container - #3489
Open
patil2001 wants to merge 1 commit into
Open
fix(windows): replace stale Hermes SOUL.md instead of guarding on Container#3489patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
…tainer Invoke-HermesSoulRefresh checked -PathType Container on a file path, so an existing SOUL.md (a Leaf) was never removed and the fallback never regenerated. Test for Leaf and remove the stale file before re-rendering. Closes Osmantic#3334
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invoke-HermesSoulRefreshin theodsCLI guarded its stale-file cleanup withTest-Path -LiteralPath $output -PathType Container.$outputis a file (data/persona/SOUL.md), so the Container check was always false — an existing SOUL.md was never removed and the fallback render was skipped. The stale template therefore persisted across refreshes.Fix
Check
-PathType Leafand remove the stale file before re-rendering.Verification
Test-Path -LiteralPath $output -PathType Leafis the correct test for a file path.Closes #3334