fix(update): iterate compose services as an array to avoid word-splitting by patil2001 · Pull Request #3502 · Osmantic/ODS

patil2001 · 2026-08-29T16:10:27Z

Summary

cmd_health in ods-update.sh captured the output of docker compose ps --services in a scalar variable and iterated it with for service in $services. docker compose ps --services emits one service name per line, so the unquoted expansion word-splits on whitespace: any service whose name contains a space is torn into fragments and probed as a partial name, producing a false unknown/unhealthy report.

This change reads the service list into an array with mapfile and iterates over whole elements, so multi-word service names stay intact. The empty-case check now uses the array length.

Test plan

bash -n ods/ods-update.sh
On a running stack, the health check reports each service correctly; add a service whose name contains a space and confirm it is no longer split.

Fixes #3339

…ting cmd_health stored the 'docker compose ps --services' output in a scalar and iterated it with 'for service in $services', which word-splits service names on whitespace. Any service whose name contains a space was split into tokens and probed as a fragment, reporting a false unhealthy status. Read the service list into an array with mapfile and iterate over whole elements so multi-word service names stay intact. Fixes Osmantic#3339

tang-vu mentioned this pull request Aug 30, 2026

fix(update): confine rollback targets to backup roots #3542

Open

8 tasks

Navigation Menu

Uh oh!

fix(update): iterate compose services as an array to avoid word-splitting - #3502

fix(update): iterate compose services as an array to avoid word-splitting#3502
patil2001 wants to merge 1 commit into
Osmantic:mainfrom
patil2001:fix/health-loop-service-array

patil2001 commented Aug 29, 2026

Labels

1 participant