fix(macos): trust auto-capped voice CPU budgets - #3607
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
On an 8-core M1,
install-macos.sh --allaborts before setup because voice selection raises the Docker CPU floor from 6 to 10. That gate is obsolete: the shipped macOS env generator now caps TTS, Whisper, Hermes, and ComfyUI CPU limits to the daemon's actual CPU count. The installer therefore rejects a Compose plan it can generate and run safely (reported in #3600).Root cause: the installer retained two feature-specific preflight checks from before bundled service CPU limits became daemon-capped in #1362.
Invariant: optional feature selection must not raise the baseline Docker CPU requirement when every optional service limit is capped to the detected daemon capacity. An explicit
ODS_MIN_DOCKER_CPUSoperator policy remains authoritative.What changed
Overlap check
Searched open and closed PRs for
macOS voice CPU budget,voice-enabled compose stack, issue #3600, and changes toods/installers/macos/install-macos.sh. #1362 is the merged producer-side CPU-cap change; it does not remove the now-stale consumer gate. No open PR covers this installer rejection.Regression boundary
tests/test-macos-installer-transitions.shnow asserts the public installer flow has exactly one baseline CPU gate, retains the six-CPU/operator-override contract, and cannot reintroduce a voice-specific floor. The existing generated-env smoke test separately proves TTS and all bundled service limits stay within the Docker CPU count.Validation
bash tests/test-macos-installer-transitions.sh— passbash -n installers/macos/install-macos.sh tests/test-macos-installer-transitions.sh— passgit diff --check— passbash tests/smoke/installer-env-smoke.sh— CPU-cap assertions pass; suite later hits the existing unrelatedai_errundefined-function audit failure ininstallers/phases/07-devtools.shTradeoffs and rollback
This deliberately keeps the base six-CPU guard, so undersized daemon allocations still fail early. Operators who need a stricter policy can continue setting
ODS_MIN_DOCKER_CPUS. Rollback is limited to restoring the two voice gates; no persisted state or Compose schema changes.Closes #3600