feat(manifests): emit schema summaries as JSON - #3661
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-manifest-schema.sh --jsonwith strict mode, totals, valid count, errors, and warningsWhy this matters
Extension authors and release tooling run this public validator before publishing manifests. A stable receipt lets dashboards and CI aggregate validation state without scraping box-drawing output, including the distinction between accepted warnings and strict failures.
Overlap check
Searched open and closed PRs for
manifest schema validator jsonand PRs referencingods/scripts/validate-manifest-schema.sh. Open PR #2600 adds custom schema mirrors, #2328 changes validation performance, and #2669/#2574 harden schema paths; none adds a JSON summary contract. The schema rules are unchanged.Test plan
bash ods/tests/test-validate-manifest-schema.shbash -n ods/scripts/validate-manifest-schema.shgit diff --check -- ods/scripts/validate-manifest-schema.sh ods/tests/test-validate-manifest-schema.shTradeoffs and rollback
Per-manifest diagnostic text remains on stderr rather than being duplicated in the summary; counts provide the stable automation contract. The current catalog reports three accepted compose-file warnings, accurately represented without failing non-strict mode. Removing
--jsonrestores the prior surface.Generated with Codex
Batch compatibility
upstream/main@6ff9b4fc; synthetic integration head:e45e2647.make lint, andgit diff --check upstream/main...HEADpassed.tests/test-installer-context-parity.shstill fails atHermes template bounds each model turn; the identical failure was reproduced on the exact upstream base, so it is not introduced by this batch.