feat(release): emit golden-path validation JSON - #3662
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-golden-paths.py --jsonwith source, scenario count, and structured issuesWhy this matters
Golden-path validation protects the four documented installation routes before release. CI and release dashboards can now attach exact JSON paths and messages to a candidate artifact instead of parsing prose, including early file/JSON failures.
Overlap check
Searched open and closed PRs for
golden path validation jsonand PRs referencingods/scripts/validate-golden-paths.py. Open PRs #3409/#2742 harden file decoding and #2536 confines contract paths; none adds structured output. The four-scenario validation rules remain unchanged.Test plan
bash ods/tests/test-golden-paths.shpython -m py_compile ods/scripts/validate-golden-paths.pygit diff --check -- ods/scripts/validate-golden-paths.py ods/tests/test-golden-paths.shTradeoffs and rollback
Issue objects expose JSON path and message without adding a schema dependency. The human format remains default, and removing
--jsonrequires no data migration or caller rollback.Generated with Codex
Batch compatibility
upstream/main@6ff9b4fc; synthetic integration head:e45e2647.make lint, andgit diff --check upstream/main...HEADpassed.tests/test-installer-context-parity.shstill fails atHermes template bounds each model turn; the identical failure was reproduced on the exact upstream base, so it is not introduced by this batch.