Add support for 'update' command to the CLI to update itself by cteyton · Pull Request #154 · PackmindHub/packmind

cteyton · 2026-02-27T15:49:51Z

Explanation

Let users easily update the CLI to its latest version.

Type of Change

Affected Components

Domain packages affected: CLI

Testing

Unit tests added/updated
Integration tests added/updated
Manual testing completed
Test coverage maintained or improved

TODO List

CHANGELOG Updated
Documentation Updated

greptile-apps · 2026-02-27T15:52:50Z

Greptile Summary

This PR adds a self-update command to the CLI that allows users to easily update to the latest version. The implementation properly handles both npm package and standalone executable modes.

Key improvements from previous feedback:

✅ Now uses semver.gt() for proper version comparison instead of string equality
✅ GitHub releases are explicitly sorted by semver to ensure correct latest version detection
✅ All interfaces correctly prefixed with I per TypeScript code standards
✅ semver dependency added to package.json

Implementation highlights:

--check flag exits with code 1 when update is available, code 0 when up to date (enables scripting)
Proper error handling with specific messaging for permission errors
Atomic file replacement for executable updates with temp file cleanup on failure
File size validation after download to detect incomplete downloads
Comprehensive test coverage including edge cases

Confidence Score: 4/5

This PR is safe to merge with minimal risk
Score reflects well-tested implementation that addresses all previous feedback, proper error handling, and comprehensive test coverage. Minor consideration: Windows executable replacement may fail for running executables (documented limitation)
No files require special attention - all previous issues have been addressed

Important Files Changed

Filename	Overview
apps/cli/src/infra/commands/UpdateCommand.ts	New command entry point - clean implementation with proper dependency injection
apps/cli/src/infra/commands/updateHandler.ts	Core update logic with proper semver comparison, error handling, and both npm/executable update paths. Interfaces correctly prefixed with I per standards
apps/cli/src/infra/commands/updateHandler.spec.ts	Comprehensive test coverage for all update scenarios including edge cases

_{Last reviewed commit: 0be3345}

greptile-apps

_{5 files reviewed, 7 comments}

_{Edit Code Review Agent Settings | Greptile}

apps/cli/package.json

apps/cli/src/infra/commands/updateHandler.ts

vincent-psarga · 2026-02-27T16:06:20Z

apps/cli/src/infra/commands/updateHandler.ts

+
+function updateViaNpm(version: string): void {
+  logInfoConsole(`Updating via npm to version ${version}...`);
+  execSync(`npm install -g ${NPM_PACKAGE}@${version}`, {


What happens if I have @packmind/cli in my local JS dependencies (in my package.json)

My guess is that the general packmind-cli will be updated but if I run it inside my project I'll still have the old version.

I don't think this should be covered by our update command, since it would imply directly updating the package.json file.
I think it'd more the jobs of some tools like dependabot, don't you think?

- Replace string equality with semver.gt() for correct handling of versions like 0.9.0 vs 0.10.0 - Fix test names to follow verb-first naming convention - Add test for current version newer than latest Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…order Explicitly sort CLI releases using semver.rcompare to ensure the latest version is selected regardless of GitHub API response ordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

apps/cli/src/infra/commands/updateHandler.ts

- Add checkOnly boolean flag to IUpdateHandlerDependencies - Skip download/npm install when --check-update is passed - Add tests for check-only mode (update available and up to date) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cteyton · 2026-02-28T07:05:32Z

@greptile thoughts on the "--check-update" flag?

greptile-apps · 2026-02-28T07:06:20Z

Looking at the implementation, the --check-update flag is solid and useful. Here are my thoughts:

What works well:

Non-destructive checking before committing to an update
Good for automation/CI scripts that want to detect outdated installations
Clean exit without side effects when flag is present

Suggestions:

Consider shorter flag name: --check is more conventional than --check-update. Compare:
- ✅ packmind-cli update --check
- vs packmind-cli update --check-update (redundant?)
Add exit codes: When running in check-only mode, consider:
- Exit 0: Already up-to-date
- Exit 1: Update available
- This makes it easy to use in scripts: if packmind-cli update --check; then ...
Consider alternative: separate subcommand: Some CLIs use update check vs update install, but for this use case the flag approach is fine.

The implementation in updateHandler.ts handles it cleanly:

if (deps.checkOnly) {
  return;  // Exit after logging version comparison
}

Overall, it's a good addition. The only change I'd strongly recommend is shortening the flag to just --check.

apps/cli/src/infra/commands/updateHandler.ts

- Rename flag from --check-update to --check for brevity - Exit with code 1 when update is available in check-only mode - Exit with code 0 when already up to date (enables scripting) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cteyton · 2026-02-28T07:15:55Z

Looking at the implementation, the --check-update flag is solid and useful. Here are my thoughts:

What works well:

Non-destructive checking before committing to an update

Good for automation/CI scripts that want to detect outdated installations

Clean exit without side effects when flag is present

Suggestions:

Consider shorter flag name: --check is more conventional than --check-update. Compare:

✅ packmind-cli update --check

vs packmind-cli update --check-update (redundant?)

Add exit codes: When running in check-only mode, consider:

Exit 0: Already up-to-date

Exit 1: Update available

This makes it easy to use in scripts: if packmind-cli update --check; then ...

Consider alternative: separate subcommand: Some CLIs use update check vs update install, but for this use case the flag approach is fine.

The implementation in updateHandler.ts handles it cleanly:
if (deps.checkOnly) {
  return;  // Exit after logging version comparison
}
Overall, it's a good addition. The only change I'd strongly recommend is shortening the flag to just --check.

@greptile can you report on the updated version?

greptile-apps · 2026-02-28T07:16:42Z

Great news! Both of your key suggestions have been implemented:

✅ Changes Made

1. Flag shortened to --check

check: flag({
  long: 'check',
  description: 'Only check if a newer version is available without performing the update',
}),

Usage is now: packmind-cli update --check

2. Exit codes implemented
From the updateHandler implementation:

Exit 0: When already up-to-date (implicit return)
Exit 1: When update is available (explicit process.exit(1))

This makes it script-friendly:

if packmind-cli update --check; then
  echo "Up to date!"
else
  echo "Update available"
fi

The implementation is clean and follows the conventional pattern you recommended. The handler checks the version, logs the result, and exits appropriately in check-only mode before attempting any actual update.

sonarqubecloud · 2026-02-28T07:21:37Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Add support for 'update' command to the CLI to update itself

5b4ed66

greptile-apps bot reviewed Feb 27, 2026

View reviewed changes

apps/cli/package.json Outdated Show resolved Hide resolved

apps/cli/src/infra/commands/updateHandler.ts Outdated Show resolved Hide resolved

Revert incorrectly commited package.json version update

9450e14

greptile-apps bot reviewed Feb 27, 2026

View reviewed changes

apps/cli/src/infra/commands/updateHandler.ts Outdated Show resolved Hide resolved

apps/cli/src/infra/commands/updateHandler.ts Outdated Show resolved Hide resolved

apps/cli/src/infra/commands/updateHandler.ts Show resolved Hide resolved

vincent-psarga reviewed Feb 27, 2026

View reviewed changes

cteyton and others added 3 commits February 27, 2026 17:11

Rename UpdateHandlerDependencies to IUpdateHandlerDependencies

8b7f15e

🐛 fix(cli): sort GitHub releases by semver instead of relying on API …

7368fb3

…order Explicitly sort CLI releases using semver.rcompare to ensure the latest version is selected regardless of GitHub API response ordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

greptile-apps bot reviewed Feb 27, 2026

View reviewed changes

apps/cli/src/infra/commands/updateHandler.ts Show resolved Hide resolved

cteyton and others added 2 commits February 27, 2026 17:22

Add semver as dependency for apps/cli

f6b98b7

greptile-apps bot reviewed Feb 28, 2026

View reviewed changes

apps/cli/src/infra/commands/updateHandler.ts Outdated Show resolved Hide resolved

cteyton and others added 2 commits February 28, 2026 08:09

fix linting issue

7790690

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for 'update' command to the CLI to update itself#154

Add support for 'update' command to the CLI to update itself#154
cteyton wants to merge 9 commits intomainfrom
cli-update

cteyton commented Feb 27, 2026

greptile-apps bot commented Feb 27, 2026 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vincent-psarga Feb 27, 2026

cteyton Feb 27, 2026 •

edited

Loading

Uh oh!

cteyton commented Feb 28, 2026

greptile-apps bot commented Feb 28, 2026

Uh oh!

cteyton commented Feb 28, 2026

greptile-apps bot commented Feb 28, 2026

sonarqubecloud bot commented Feb 28, 2026

Labels

2 participants

Conversation

cteyton commented Feb 27, 2026

Explanation

Type of Change

Affected Components

Testing

TODO List

greptile-apps bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vincent-psarga Feb 27, 2026

Choose a reason for hiding this comment

cteyton Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cteyton commented Feb 28, 2026

greptile-apps bot commented Feb 28, 2026

Uh oh!

cteyton commented Feb 28, 2026

greptile-apps bot commented Feb 28, 2026

✅ Changes Made

sonarqubecloud bot commented Feb 28, 2026

Quality Gate passed

Labels

2 participants

greptile-apps bot commented Feb 27, 2026 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading

cteyton Feb 27, 2026 •

edited

Loading