Skip to content

Feat: Handle non-ASCII account names better#8949

Merged
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom
Nightblade:feat-handle-nonascii-account-names
Aug 20, 2025
Merged

Feat: Handle non-ASCII account names better#8949
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom
Nightblade:feat-handle-nonascii-account-names

Conversation

@Nightblade
Copy link
Contributor

Changed the .pasteFilter on import -> account name EditControl to URL-encode "non-ASCII" characters. Users can simply paste their account name as-is and hit Start.

This change eliminates the need to use www.urlencoder.org so I've removed the warning text and button.

Tested OK with:

쁘레따뽀르떼#4360

Old encoding:

%C3%AC%C2%81%C2%98%C3%AB%C2%A0%C2%88%C3%AB%C2%94%C2%B0%C3%AB%C2%BD%C2%80%C3%AB%C2%A5%C2%B4%C3%AB%C2%96%C2%BC%234360

New encoding:

%EC%81%98%EB%A0%88%EB%94%B0%EB%BD%80%EB%A5%B4%EB%96%BC%234360
Refactor the `pasteFilter` on the import -> account name EditControl to encode non-ASCII characters in a more URL-friendly manner than it was previously.

This change eliminates the need to use `www.urlencoder.org` so I've removed that warning and the button.

Tested OK with:  쁘레따뽀르떼PathOfBuildingCommunity#4360
@LocalIdentity LocalIdentity merged commit aa9f6f9 into PathOfBuildingCommunity:dev Aug 20, 2025
2 checks passed
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Aug 20, 2025
@Nightblade Nightblade deleted the feat-handle-nonascii-account-names branch August 20, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

2 participants