Skip to content

Fix EO incorrectly setting ailment chance to 0% for critical strikes#9061

Merged
LocalIdentity merged 3 commits intoPathOfBuildingCommunity:devfrom
majochem:ailmentChanceEO
Oct 30, 2025
Merged

Fix EO incorrectly setting ailment chance to 0% for critical strikes#9061
LocalIdentity merged 3 commits intoPathOfBuildingCommunity:devfrom
majochem:ailmentChanceEO

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Oct 28, 2025 •
edited
Loading

Fixes #8827 .

Allocating Elemental Overload falsely set ailment chance to 0% for critical strikes. However, it should only make ailments from crit be treated as if they were from non-critical strikes.

So the chance should only be 0% if Perfect Agony is also allocated.

Link to relevant section on Wiki

Steps taken to verify a working solution:

  • Ailment chance is now unaffected by EO (except for chance modifiers specifically affecting critical strikes)
  • Ailment multipliers are correctly affected by EO (assumes non-crit)
  • Ailment chance is correctly set to 0% if both EO and Perfect Agony are allocated
  • EO disables inherent ability to inflict elemental ailments likes Freeze, Shock, Ignite, Brittle, Scorch, Sap
  • EO disables chance modifiers that only apply to critical strikes like "Adder's Touch" passive notable

Limitations:

  • The breakdowns are still somewhat misleading / lack information. I originally also wanted to change that in the same PR, but it turned out to be a deeper rabbit hole than expected, so I am postponing it
  • There is still something else wrong with the displayed bleed chance, if chance to bleed differs between crit and non-crit (see 19% chance to bleed in before screenshot), but that will also have to go in a different PR and is not directly related to the EO interaction
  • There are some lingering problems with the way "portion of critical" strikes is (not) handled during ailment calculation. E.g. if you have "x% increased duration of ailments from critical strikes" it will apply to non-critical strikes as well because the duration is simply overwritten rather than being tracked separately like chance and multi. This is not a problem for now because no such mod exists, but it might be in the future.

Link to a build that showcases this PR:

Ailment Test Build

Before screenshot:

With EO:
image
image
image

After screenshot:

With EO:
image
image
image

With PA and EO: (No more ailments)
image

With just PA (Bleed chance is still wrong, as mentioned in "Limitations":
image
@majochem
Fix crit ailment chance calc with EO
55fd0b5 
Allocating Elemental Overload falsely set ailment chance to `0%` for
critical strikes. However, it should only make ailments from crit be
treated as if they were from non-critical strikes.

So the chance should only be `0%` if Perfect Agony is also allocated.
@majochem
Disable "CRIT" ailment mode if EO is allocated
fc1010c 
This was mostly for effects on non-damaging ailments
@majochem
Implement undocumented 3.25 changes to EO
b61400c 
- After an undocumented mechanical change in version 3.25.0 (the stat text
  did not change), this stat also appears to prevent any conditional
  stats or interactions for ailments on critical strike.[3] For example,
  this prevents the inherent ability to apply elemental ailments on crit,
  and also prevents Adder's Touch or Secrets of Suffering from applying
  poison or alternate ailments on crit. Note that it does not prevent the
  application of ailments from chance-based sources or chill on a hit
  that critically strikes, though the ailment will not be considered from
  a crit and cannot be scaled through crit-related stats.

- If combined with Perfect Agony, you will no longer be able to apply
  ailments with hits.
@majochem majochem marked this pull request as ready for review October 28, 2025 11:53
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Oct 30, 2025
@LocalIdentity LocalIdentity merged commit 6fb29aa into PathOfBuildingCommunity:dev Oct 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

2 participants

@majochem @LocalIdentity