Merged
Conversation
Owner
Author
|
@andreivladbrg @smol-ninja could you PTAL to check if this PR doesn't break Flow? |
Collaborator
As far as I can see, the changes made in this PR are related to the casting function and not specifically to the newly added types. Therefore, I don’t see any issues that would cause a break in |
Owner
Author
|
Well, the PR is related to the new types insofar it removes some of their functionalities. can you please install PRBMath from this branch and confirm that the code still compiles? |
Collaborator
|
But, I've tested on this commit, and the build runs. |
Owner
Author
|
Thanks @andreivladbrg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #236