[WIP] Adding `qml.OutPoly' #6320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Contributor
Author
|
[sc-72629] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6320 +/- ##
==========================================
- Coverage 99.38% 99.38% -0.01%
==========================================
Files 450 452 +2
Lines 42619 42771 +152
==========================================
+ Hits 42359 42509 +150
- Misses 260 262 +2 ☔ View full report in Codecov by Sentry. |
DSGuala
reviewed
Oct 4, 2024
willjmax
reviewed
Oct 7, 2024
Contributor
willjmax
left a comment
willjmax
left a comment
There was a problem hiding this comment.
Here are some initial comments. I will look over the Mobius transformation in my next review.
obliviateandsurrender
requested changes
Oct 8, 2024
Contributor
obliviateandsurrender
left a comment
obliviateandsurrender
left a comment
There was a problem hiding this comment.
Leaving some initial comments, will take a closer look at the decomposition next.
obliviateandsurrender
approved these changes
Oct 24, 2024
Contributor
obliviateandsurrender
left a comment
obliviateandsurrender
left a comment
There was a problem hiding this comment.
Thanks @KetpuntoG, overall looks good!
soranjh
requested changes
Oct 24, 2024
soranjh
approved these changes
Oct 24, 2024
Contributor
obliviateandsurrender
left a comment
obliviateandsurrender
left a comment
There was a problem hiding this comment.
Thanks @KetpuntoG, some more suggestion regarding docs; after which it should be 🚀
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
[skip ci] Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
…into qml_outpoly
mudit2812
pushed a commit
that referenced
this pull request
Nov 11, 2024
To do:
- [x] Final review
- [x] Add thumbnail
- [x] Add changeling
In this PR we add `qml.OutPoly`. An operator that allows to apply
arbitrary polynomials on quantum registers.
Example where we want to create the operator:
$$U|x\rangle |y\rangle |0\rangle = |x\rangle |y\rangle |x^2 + y\rangle$$
```python
import pennylane as qml
x_wires = [0, 1, 2]
y_wires = [3, 4, 5]
output_wires = [6, 7, 8]
def f(x, y):
return x ** 2 + y
@qml.qnode(qml.device("default.qubit", shots = 1))
def circuit():
# loading values for x and y
qml.BasisEmbedding(2, wires=x_wires)
qml.BasisEmbedding(2 , wires=y_wires)
# applying the polynomial
qml.OutPoly(f,
input_registers = [x_wires, y_wires],
output_wires=output_wires)
return qml.sample(wires=output_wires)
print(circuit())
```
**Context:**
This operator is born of the quantum arithmetic project
**Benefits:**
complete flexibility for the user to create new arithmetic operators
[[sc-72629](https://app.shortcut.com/xanaduai/story/72629/support-polynomial-arithmetic)]
---------
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: Will <wmaxwell90@gmail.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
In this PR we add
qml.OutPoly. An operator that allows to apply arbitrary polynomials on quantum registers.Example where we want to create the operator:
$$U|x\rangle |y\rangle |0\rangle = |x\rangle |y\rangle |x^2 + y\rangle$$
Context:
This operator is born of the quantum arithmetic project
Benefits:
complete flexibility for the user to create new arithmetic operators
[sc-72629]