Skip to content

Conversation

@KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Oct 30, 2024

Context:

This PR appears in the context of the QSVT project, specifically focusing on the implementation of the angle solver, functionality to calculate the angles needed to apply a polynomial transformation.

Description of the Change:

Added qml.poly_to_angles, the main functionality of the PR that takes as input a polynomial and returns the angles.
Also included is the function qml.transform_angles, which transforms the angle format between qsp and qsvt.
Both these functions and other auxiliary functions have been added in qsvt.py.

Benefits:

Calculating angles is not a simple task and existing libraries have some limitations. With this new functionality we will facilitate the use of routines such as qsp and qsvt.

Possible Drawbacks:

Currently only one solver has been introduced. In the future it is expected to add more that will work for more extreme cases: larger polynomials (degree > 1000) or degenerate polynomials

[sc-72631]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.
@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (01c7c28) to head (5546c5d).
Report is 292 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6483   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         456      456           
  Lines       42993    43060   +67     
=======================================
+ Hits        42844    42911   +67     
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soranjh soranjh changed the title Angle solver qsp/qsvt Oct 30, 2024
@soranjh soranjh added the do not merge ⚠️ Do not merge the pull request until this label is removed label Oct 30, 2024
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KetpuntoG, left my first round of comments.

KetpuntoG and others added 2 commits November 22, 2024 11:34
[skip ci]

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@KetpuntoG KetpuntoG requested a review from soranjh November 22, 2024 18:28
@AntonNI8 AntonNI8 self-requested a review November 26, 2024 14:53
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side! just a few small suggestions

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KetpuntoG, left a final set of comments.

KetpuntoG and others added 4 commits November 29, 2024 10:39
@KetpuntoG KetpuntoG requested a review from soranjh November 29, 2024 19:25
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few minor comments.

KetpuntoG and others added 3 commits November 29, 2024 15:34
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the final points.

KetpuntoG and others added 3 commits November 29, 2024 16:24
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
@KetpuntoG KetpuntoG merged commit 77c56b7 into master Nov 29, 2024
46 checks passed
@KetpuntoG KetpuntoG deleted the angle_solver_qsp branch November 29, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants