Skip to content

Support the construction of bosonic operators #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 103 commits into from
Nov 22, 2024
Merged

Support the construction of bosonic operators #6518

merged 103 commits into from
Nov 22, 2024

Conversation

@austingmhuang
Copy link
Contributor

@austingmhuang austingmhuang commented Nov 5, 2024 •
edited
Loading

Context:
We need BoseWords and BoseSentences to help us build vibrational hamiltonians.

Description of the Change:
Add BoseWords and BoseSentences

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-72640]
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.
ddhawan11
ddhawan11 requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@ddhawan11 ddhawan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austingmhuang. A couple of minor comments from me.
@austingmhuang austingmhuang requested a review from soranjh November 7, 2024 22:16
soranjh
soranjh requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austingmhuang, left some comments. The test file seems to be incomplete.
austingmhuang and others added 12 commits November 8, 2024 16:45
@austingmhuang @soranjh
Update pennylane/labs/tests/vibrational_ham/test_bosonic.py
f33f120 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/labs/vibrational_ham/bosonic.py
f0819be 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/labs/vibrational_ham/bosonic.py
86fc4d6 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/labs/vibrational_ham/bosonic.py
82a366a 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/labs/vibrational_ham/bosonic.py
09f9981 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@austingmhuang
Merge branch 'master' into bose_operators
6bc979d
@austingmhuang
Merge branch 'master' into bose_operators
18762b5
@austingmhuang
[skip ci] black
4beccf1
@austingmhuang
Merge branch 'master' into bose_operators
c493be4
@austingmhuang
change name to vibrational
718fe06
@austingmhuang
shift operator draft
4141d05
@austingmhuang
shift operator
fefa2cf
ddhawan11
ddhawan11 reviewed Nov 21, 2024
View reviewed changes
soranjh
soranjh reviewed Nov 21, 2024
View reviewed changes
obliviateandsurrender
obliviateandsurrender approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some optional comments.
austingmhuang and others added 2 commits November 21, 2024 10:58
@austingmhuang @obliviateandsurrender
Update doc/releases/changelog-dev.md
72b7973 
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
@austingmhuang
fix
e79dc62
ddhawan11
ddhawan11 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ddhawan11 ddhawan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side, good work @austingmhuang
soranjh
soranjh approved these changes Nov 21, 2024
View reviewed changes
@austingmhuang @soranjh
Update doc/releases/changelog-dev.md
21e8aec 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@austingmhuang austingmhuang added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Nov 21, 2024
DSGuala
DSGuala reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@DSGuala DSGuala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good overall.

I'm wondering whether qml.qchem.BoseWord should be qml.bose.BoseWord for consistency with qml.fermi.FermiWord. Not a blocker.

I had some trouble with arithmetic, but the tests are passing, so maybe it's something on my end?
@austingmhuang
Copy link
Contributor Author

austingmhuang commented Nov 21, 2024 •
edited
Loading

I'm wondering whether qml.qchem.BoseWord should be qml.bose.BoseWord for consistency with qml.fermi.FermiWord. Not a blocker.

Hmmm.... this is kind of a good point actually. @soranjh I think it is fine in qchem personally, but do you think this should be changed?
@soranjh
Copy link
Contributor

soranjh commented Nov 21, 2024 •
edited
Loading

I'm wondering whether qml.qchem.BoseWord should be qml.bose.BoseWord for consistency with qml.fermi.FermiWord. Not a blocker.

Hmmm.... this is kind of a good point actually. @soranjh I think it is fine in qchem personally, but do you think this should be changed?

Yes, what @DSGuala suggested for creating a bose folder makes sense. We can add a proper qml_bose.rst file in doc/code, in a separate PR when the mapping PRs are merged.
soranjh
soranjh reviewed Nov 21, 2024
View reviewed changes
DSGuala
DSGuala approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go! 💪
@austingmhuang austingmhuang enabled auto-merge (squash) November 22, 2024 14:23
@austingmhuang austingmhuang merged commit 9c1292d into master Nov 22, 2024
45 checks passed
@austingmhuang austingmhuang deleted the bose_operators branch November 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-ready ✔️ All tests pass and the PR is ready to be merged.

6 participants

@austingmhuang @soranjh @obliviateandsurrender @ddhawan11 @DSGuala