[Capture] Add finite differences jvps #6853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello. You may have forgotten to update the changelog!
|
…pennylane into finite-diff-capture
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6853 +/- ##
=======================================
Coverage 99.54% 99.55%
=======================================
Files 477 478 +1
Lines 45246 45343 +97
=======================================
+ Hits 45042 45140 +98
+ Misses 204 203 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrijapau
reviewed
Jan 23, 2025
mudit2812
reviewed
Jan 24, 2025
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
andrijapau
reviewed
Jan 24, 2025
andrijapau
reviewed
Jan 24, 2025
mudit2812
reviewed
Jan 24, 2025
mudit2812
reviewed
Jan 24, 2025
Contributor
mudit2812
left a comment
mudit2812
left a comment
There was a problem hiding this comment.
Forgot to say in the last review, but could you also add a test for differentiating for complex parameters? Other than that, I'm ready to approve.
andrijapau
reviewed
Jan 24, 2025
Co-authored-by: Andrija Paurevic <46359773+andrijapau@users.noreply.github.com>
andrijapau
reviewed
Jan 27, 2025
mudit2812
approved these changes
Jan 27, 2025
andrijapau
approved these changes
Jan 27, 2025
Contributor
andrijapau
left a comment
andrijapau
left a comment
There was a problem hiding this comment.
Just some non-blocking suggestions for documentation. I think it aligns more with the documentation guide.
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai> Co-authored-by: Andrija Paurevic <46359773+andrijapau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently, program capture only supports differentiation with backprop. This is only supported on
default.qubitDescription of the Change:
Adds the capability to take finite difference derivatives.
Benefits:
We can now differentiate anything, and we can differentiate with the lightnings.
Possible Drawbacks:
finite diff tends to be noisy to the point of uselessness.
Related GitHub Issues:
[sc-82167]