-
Notifications
You must be signed in to change notification settings - Fork 714
Implement a CollectResourceOps for the new decomposition system.
#7184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7184 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 510 511 +1
Lines 49714 49770 +56
=======================================
+ Hits 49538 49594 +56
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerryChen97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work! The current implementation is in excellent shape, with clear structure and strong maintainability. Given the complexity of the new decomposition system, we won’t identify every potential issue at this stage. We’ll discover and address the next steps as we gain more practical experience with it.
mudit2812
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks great! Just left some comments about testing.
Context:
For the new decomposition system, we want an interpreter that does a first pass analysis of the circuit and collect all operator types (
CompressedResourceOp) that potentially need to be decomposed. It is essentially the same asCollectOpsandMeas, except that it:cond_primbecause operators in all branches may need to be decomposed.CompressedResourceOprather than a list ofOperator.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-87632]