-
Notifications
You must be signed in to change notification settings - Fork 714
Elbow operator #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elbow operator #7472
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7472 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 530 531 +1
Lines 52148 52224 +76
=======================================
+ Hits 51985 52061 +76
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dwierichs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clear addition! 💯
I left a series of initial comments, nothing fundamental or major :)
dwierichs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to go from my side.
I'll approve once the name is finalized! :)
soranjh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KetpuntoG, left some comments on the docs.
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
dwierichs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had some final non-blocking comments, except for the request to add a comment in the example about the output state having to be |0>, and to test the alias to actually be an alias, not just some functional op.
dwierichs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the quick amendments 💯 🙏
Great job @KetpuntoG
AntonNI8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Co-authored-by: ANTH0NY <39093564+AntonNI8@users.noreply.github.com>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[sc-91810]
Description of the Change:
Adding the elbows operators described in: https://arxiv.org/abs/1805.03662
Benefits:
More efficient decomposition in templates
Possible Drawbacks:
Right now we can't apply MCMs, we will have to update the operator in the future for the Adjoint(elbow)
Related GitHub Issues: