Skip to content

Conversation

@KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented May 23, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-91810]

Description of the Change:

Adding the elbows operators described in: https://arxiv.org/abs/1805.03662

Screenshot 2025-05-23 at 10 19 00 AM

Benefits:

More efficient decomposition in templates

Possible Drawbacks:

Right now we can't apply MCMs, we will have to update the operator in the future for the Adjoint(elbow)
Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (362d9e3) to head (5ec2b92).
⚠️ Report is 407 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7472   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files         530      531    +1     
  Lines       52148    52224   +76     
=======================================
+ Hits        51985    52061   +76     
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@KetpuntoG KetpuntoG requested a review from Jaybsoni May 23, 2025 17:46
@KetpuntoG KetpuntoG requested a review from AntonNI8 May 23, 2025 18:23
@dwierichs dwierichs self-requested a review May 27, 2025 12:31
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear addition! 💯
I left a series of initial comments, nothing fundamental or major :)

KetpuntoG and others added 3 commits May 27, 2025 10:09
[skip-ci]

Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
@KetpuntoG KetpuntoG requested a review from dwierichs May 28, 2025 01:25
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to go from my side.
I'll approve once the name is finalized! :)

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KetpuntoG, left some comments on the docs.

@KetpuntoG KetpuntoG requested a review from soranjh June 9, 2025 21:43
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had some final non-blocking comments, except for the request to add a comment in the example about the output state having to be |0>, and to test the alias to actually be an alias, not just some functional op.

KetpuntoG and others added 3 commits June 10, 2025 08:46
[skip ci]

Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
@KetpuntoG KetpuntoG requested a review from dwierichs June 10, 2025 13:33
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the quick amendments 💯 🙏
Great job @KetpuntoG

KetpuntoG and others added 4 commits June 10, 2025 10:24
@KetpuntoG KetpuntoG enabled auto-merge June 10, 2025 15:14
Copy link
Contributor

@AntonNI8 AntonNI8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Co-authored-by: ANTH0NY <39093564+AntonNI8@users.noreply.github.com>
@KetpuntoG KetpuntoG disabled auto-merge June 10, 2025 16:24
@KetpuntoG KetpuntoG added this pull request to the merge queue Jun 10, 2025
Merged via the queue into master with commit 6410b8d Jun 10, 2025
53 checks passed
@KetpuntoG KetpuntoG deleted the elbow branch June 10, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants