Adding qml.SemiAdder Template
#7494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KetpuntoG
force-pushed
the
semi_out_adder_gidney
branch
from
fe9d739 to
15449dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7494 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 532 533 +1
Lines 52527 52617 +90
=======================================
+ Hits 52357 52447 +90
Misses 170 170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KetpuntoG
force-pushed
the
semi_out_adder_gidney
branch
from
c4e275b to
db42cdc
Compare
Co-authored-by: ANTH0NY <39093564+AntonNI8@users.noreply.github.com>
…I/pennylane into semi_out_adder_gidney
Jaybsoni
approved these changes
Jun 13, 2025
Contributor
Jaybsoni
left a comment
Jaybsoni
left a comment
There was a problem hiding this comment.
Looks good to me on the technical side, I haven't reviewed the docs so please double check those before merging.
obliviateandsurrender
approved these changes
Jun 13, 2025
soranjh
reviewed
Jun 13, 2025
Contributor
soranjh
left a comment
soranjh
left a comment
There was a problem hiding this comment.
Thanks @KetpuntoG, left a few comments on the docs.
…I/pennylane into semi_out_adder_gidney
soranjh
reviewed
Jun 16, 2025
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
soranjh
reviewed
Jun 16, 2025
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
soranjh
approved these changes
Jun 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[sc-87475]
Description of the Change:
New qml.SemiAdder template added using state of the art decomposition
Benefits:
Possible Drawbacks:
Related GitHub Issues: