Skip to content

Conversation

@ddhawan11
Copy link
Contributor

@ddhawan11 ddhawan11 commented Sep 4, 2025

Context:
Move the wires manager class to manage the auxiliary qubits from labs to PennyLane

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-96876]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.
@ddhawan11 ddhawan11 marked this pull request as ready for review September 5, 2025 00:34
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (0f2a1e8) to head (a0e8472).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8203      +/-   ##
==========================================
- Coverage   99.40%   99.40%   -0.01%     
==========================================
  Files         548      550       +2     
  Lines       56913    56969      +56     
==========================================
+ Hits        56575    56630      +55     
- Misses        338      339       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ddhawan11 ddhawan11 requested a review from astralcai September 5, 2025 13:40
@ddhawan11 ddhawan11 changed the title Add wires manager Sep 5, 2025
Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess borrowing algorithmic/dirty wires is not supported here? There is only grabbing clean (zeroed) wires and returning them in the zeroed state?

ddhawan11 and others added 2 commits September 5, 2025 14:48
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
@astralcai
Copy link
Contributor

I just feel that overall we need better naming and better documentation for what everything means. It seems that the word "allocate" means opposite things in RE and in core PL. This can be a source of confusion.

Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind renaming any to any_state to avoid clashing with python's built in function as well as being more consistent with core PL terminology?

@andrijapau
Copy link
Contributor

Just waiting for docs to render 😃

Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for putting up with the review process! ❤️

Copy link
Contributor

@AntonNI8 AntonNI8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ddhawan11 and others added 5 commits September 10, 2025 12:38
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
Co-authored-by: Austin Huang <austin.huang@xanadu.ai>
@ddhawan11 ddhawan11 enabled auto-merge September 10, 2025 17:20
@ddhawan11 ddhawan11 added this pull request to the merge queue Sep 10, 2025
Merged via the queue into master with commit e4e3d86 Sep 10, 2025
52 checks passed
@ddhawan11 ddhawan11 deleted the add_wires_manager branch September 10, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

9 participants