-
Notifications
You must be signed in to change notification settings - Fork 714
Add wires manager for resource estimation #8203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8203 +/- ##
==========================================
- Coverage 99.40% 99.40% -0.01%
==========================================
Files 548 550 +2
Lines 56913 56969 +56
==========================================
+ Hits 56575 56630 +55
- Misses 338 339 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
astralcai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess borrowing algorithmic/dirty wires is not supported here? There is only grabbing clean (zeroed) wires and returning them in the zeroed state?
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
|
I just feel that overall we need better naming and better documentation for what everything means. It seems that the word "allocate" means opposite things in RE and in core PL. This can be a source of confusion. |
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Co-authored-by: Andrija Paurevic <46359773+andrijapau@users.noreply.github.com>
andrijapau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind renaming any to any_state to avoid clashing with python's built in function as well as being more consistent with core PL terminology?
|
Just waiting for docs to render 😃 |
andrijapau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for putting up with the review process! ❤️
AntonNI8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
Co-authored-by: Austin Huang <austin.huang@xanadu.ai>
Context:
Move the wires manager class to manage the auxiliary qubits from labs to PennyLane
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-96876]