Skip to content

Port trotter and compact hamiltonian resource templates #8303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 751 commits into from
Oct 2, 2025
Merged

Port trotter and compact hamiltonian resource templates #8303

merged 751 commits into from
Oct 2, 2025

Conversation

@austingmhuang
Copy link
Contributor

@austingmhuang austingmhuang commented Sep 18, 2025 •
edited
Loading

Context:
We move the trotter and compact hamiltonian resource operators/classes from labs into pennylane core.

TrotterCDF
TrotterProduct
TrotterTHC
TrotterVibrational
TrotterVibronic
CompactHamiltonian

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-96876]
@austingmhuang austingmhuang changed the base branch from master to add-single-paramteric-ops September 18, 2025 19:13
@austingmhuang austingmhuang changed the base branch from add-single-paramteric-ops to add-subroutines-to-estimator September 18, 2025 19:14
soranjh
soranjh reviewed Sep 19, 2025
View reviewed changes
soranjh and others added 27 commits September 19, 2025 14:12
@soranjh
fix pylint
af2ec38
@austingmhuang @soranjh
Update pennylane/estimator/templates/compact_hamiltonian.py
2d2eebc 
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/estimator/templates/trotter.py
087df56 
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/estimator/templates/trotter.py
eb2f020 
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
@austingmhuang @soranjh
Update pennylane/estimator/templates/trotter.py
131a11e 
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
@austingmhuang
Merge branch 'add-subroutines-to-estimator' into add_trotter_and_comp…
8a69500 
…actH
@austingmhuang
clean -> zeroed, etc
ddbd919
@soranjh
fix doc
b5b4d06
@soranjh
[skip ci] fix doc
7e20816
@ddhawan11
Merge branch 'master' into add-controlled-ops
471a730
@ddhawan11
fixed unwanted changes
aa67d96
@soranjh
fix doc links
8b7f4b2
@ddhawan11
Resolved conflicts
f68bf6d
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
4cad155 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
35dc4f8 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
ce03cd7 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
7a43383 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
b5b8f22 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
4c1ad60 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
0d80499 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/qubit/parametric_ops_multi_qubit.py
6be8c88 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
df9dbaf 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11 @AntonNI8
Update pennylane/estimator/ops/op_math/symbolic.py
ba3cfbd 
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com>
@ddhawan11
Merge remote-tracking branch 'origin/add-control-adjoint-symbolic' in…
88b6eab 
…to add-multi-qubit-parametric
@soranjh
fix links
bff5072
@ddhawan11
Addressed comments
8a453f4
@ddhawan11
Added mcx for cnot controlled
ab60a03
andrijapau
andrijapau reviewed Oct 1, 2025
View reviewed changes
soranjh
soranjh reviewed Oct 1, 2025
View reviewed changes
andrijapau
andrijapau approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks for doing the refactor!
AntonNI8
AntonNI8 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@AntonNI8 AntonNI8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
@soranjh soranjh enabled auto-merge October 2, 2025 14:21
@soranjh soranjh added this pull request to the merge queue Oct 2, 2025
Merged via the queue into master with commit 25b689d Oct 2, 2025
54 checks passed
@soranjh soranjh deleted the add_trotter_and_compactH branch October 2, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet