Skip to content

Added general form of transitive closure #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Procatv wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added general form of transitive closure #1257

Procatv wants to merge 2 commits into from

Conversation

@Procatv
Copy link
Contributor

@Procatv Procatv commented Jul 29, 2024 •
edited
Loading

Resolves #704

Bulids on PR #707 (Not pushed yet) to implement the general form of the transitive closure of a graph. Implemented function by following structure from @IvanIsCoding:

  • Condense the graph into strongly connect components (which we already implement)
  • Apply the DAG algorithm and get the transitive closure for the intermediate graph
  • Map the answer from the intermediate graph to the original graph

On my testing branch containing the #707 PR as well, all tests pass.
@IvanIsCoding
Copy link
Collaborator

IvanIsCoding commented Jul 29, 2024

CI should be unblocked now that #1258 is merged
@IvanIsCoding IvanIsCoding added this to the 0.16.0 milestone Nov 16, 2024
@IvanIsCoding IvanIsCoding modified the milestones: 0.16.0, 0.17.0 Dec 4, 2024
@IvanIsCoding IvanIsCoding modified the milestones: 0.17.0, 0.17.1 Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Procatv @IvanIsCoding