Allow some custom return types to be annotated as generic classes at runtime #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12818984732Details
💛 - Coveralls |
IvanIsCoding
commented
Jan 14, 2025
| key: &Bound<'_, PyAny>, | ||
| ) -> PyResult<PyObject> { | ||
| let class_string = stringify!($name); | ||
| const ALLOWED_GENERIC_CLASSES: [&str; 3] = |
Collaborator
Author
There was a problem hiding this comment.
Out of all changes this is the one I am least confident about because it feels like a hack
Merged
Collaborator
Author
|
Putting this on-hold again as it could profit from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1345
Follow up of #1348
True diff: IvanIsCoding/rustworkx@class-get-item...IvanIsCoding:rustworkx:pep563-custom-return-types
After #1348 is merged this should be easier to review