Skip to content

Fix OnWarmupFinished timing with ScheduledUniverseSelectionModel#9445

Open
JosueNina wants to merge 1 commit intoQuantConnect:masterfrom
JosueNina:bug-9333-on-warmup-finished-timing
Open

Fix OnWarmupFinished timing with ScheduledUniverseSelectionModel#9445
JosueNina wants to merge 1 commit intoQuantConnect:masterfrom
JosueNina:bug-9333-on-warmup-finished-timing

Conversation

@JosueNina
Copy link
Copy Markdown
Collaborator

Description

OnWarmupFinished was firing at the scheduled universe trigger time (e.g. 8 AM) instead of StartDate (midnight) when no midnight slice existed, now aligned to StartDate before the callback fires.

Related Issue

Closes #9333

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

It was tested using a regression test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant