Make expect+async and AsyncExpression conform to Sendable #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2023
Draft
younata
added a commit
that referenced
this pull request
Mar 17, 2024
younata
added a commit
that referenced
this pull request
Apr 11, 2024
younata
added a commit
that referenced
this pull request
Jun 18, 2024
younata
added a commit
that referenced
this pull request
Oct 14, 2024
younata
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the goals of Nimble 13 is to enable strict concurrency checking, in preparation for Swift 6 (ideally, we want to be able to support Swift 6 long before it actually ships).
This is one small part of that effort. Specifically, this is doing the least amount of work to make
AsyncExpressionandexpect/expecta(with async closures) conform to Sendable.This...
AsyncExpressionconform to Sendable.SourceLocationconform to Sendable.AsyncExpressionto take in/operate only on Sendable closures. Which drove out makingexpect(for async)/expectatake in only Sendable closures.memoizedClosure(async) to be an Actor, the new MemoizedClosure actor.As-is, this will cause a bunch of compiler warnings when it ships. Still, that's annoying enough that I'm going to consider that a breaking change.