Add cstring header explictly as it is removed from HIP #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP https://github.com/ROCm/rccl-tests/pull/132/files to master
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
What were the changes?
Add < cstring > header to fix the below errors such as "./common.h:202:10: error: use of undeclared identifier 'strncpy'"
Why were the changes made?
As part of 7.0 breaking changes, HIP runtime header files (hip_runtime.h) stopped including headers such as < cstring > or < string.h > since they were not used in hip runtime. But the apps depending on that header file will fail with the errors and those need to add the header explicitly.
How was the outcome achieved?
By adding < cstring > header.