Skip to content

[BUILD] Add link to libdl for RCCL-Tests builds #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2025
Merged

[BUILD] Add link to libdl for RCCL-Tests builds #153

merged 3 commits into from
Oct 5, 2025

Conversation

@nileshnegi
Copy link
Collaborator

@nileshnegi nileshnegi commented Sep 30, 2025 •
edited
Loading

Details

Work item:
Internal

What were the changes?
Add link to libdl in RCCL-Tests CMake and Makefile builds.

Why were the changes made?
RCCL-Tests builds on TheRock were failing due to the dependency on libdl as a result of the newly added function loadRcclSyms() 0c94d4d#diff-213de7a2fa0f343bb516d575946d5ab3675c03f4be0b493607f08ad7bf71d0d5R41
@araravik-psd araravik-psd self-requested a review September 30, 2025 22:39
araravik-psd
araravik-psd approved these changes Sep 30, 2025
View reviewed changes
Copy link

@araravik-psd araravik-psd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

With the above CMake changes I got the rccl-tests build and configure to work locally

[rccl-tests] [39/49] Linking CXX executable alltoall_perf
[rccl-tests] [40/49] Linking CXX executable broadcast_perf
[rccl-tests] [41/49] Linking CXX executable all_gather_perf
[rccl-tests] [42/49] Linking CXX executable sendrecv_perf
[rccl-tests] [43/49] Linking CXX executable reduce_perf
[rccl-tests] [44/49] Linking CXX executable reduce_scatter_perf
[rccl-tests] [45/49] Linking CXX executable all_reduce_perf
[rccl-tests] [46/49] Linking CXX executable scatter_perf
[rccl-tests] [47/49] Linking CXX executable hypercube_perf
[rccl-tests] [48/49] Linking CXX executable alltoallv_perf
[rccl-tests] [49/49] Linking CXX executable gather_perf
[rccl-tests SUCCEEDED in 10 seconds]
alex-breslow-amd
alex-breslow-amd approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@alex-breslow-amd alex-breslow-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@nileshnegi nileshnegi changed the title [BUILD] Add link to libdl for RCCL-Tests CMake builds on TheRock Oct 1, 2025
@nileshnegi
Copy link
Collaborator Author

nileshnegi commented Oct 1, 2025

Jason Koh informed that he was seeing errors related to dlopen in Makefile-based builds as well, so added ldl in src/Makefile.
corey-derochie-amd
corey-derochie-amd reviewed Oct 1, 2025
View reviewed changes
@corey-derochie-amd
Copy link
Contributor

corey-derochie-amd commented Oct 1, 2025

@nileshnegi CI tests are failing on gfx90a. Is this a pre-existing issue?
@nileshnegi
Copy link
Collaborator Author

nileshnegi commented Oct 3, 2025

@nileshnegi CI tests are failing on gfx90a. Is this a pre-existing issue?

seems like it.
@nileshnegi
Copy link
Collaborator Author

nileshnegi commented Oct 5, 2025

passed all CI checks.
@nileshnegi nileshnegi merged commit d0a99b1 into ROCm:develop Oct 5, 2025
2 checks passed
@nileshnegi nileshnegi deleted the fix/cmake-theRock branch October 5, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@nileshnegi @corey-derochie-amd @mustafabar @araravik-psd @alex-breslow-amd