Skip to content

fix: InvalidSystemClockException in concurrent #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobThree merged 1 commit into from
May 6, 2020
Merged

fix: InvalidSystemClockException in concurrent #23

RobThree merged 1 commit into from
May 6, 2020

Conversation

@larrynung
Copy link

@larrynung larrynung commented May 6, 2020

fix: InvalidSystemClockException in concurrent

Set timestamp outside lock will cause timestamp lower than _lastgen when concurrent run
@RobThree RobThree merged commit 751bbcd into RobThree:master May 6, 2020
@RobThree
Copy link
Owner

RobThree commented May 6, 2020

Hmm, I don't know what happened here but it was introduced at b582617 ...

Thanks for pointing it out and the PR! 👍

I will publish a new version soon.
@larrynung
Copy link
Author

larrynung commented May 6, 2020 •
edited
Loading

  • Thread A, B invoke CreateIdImpl in concurrent
  • Thread B set timestamp
  • Thread A set timestamp
  • Thread A enter lock block, and update _lastgen
  • Thread B enter lock block after thread A leave lock block
  • Thread B will throw InvalidSystemClockException because timestamp is smaller than _lastgen
RobThree added a commit that referenced this pull request May 6, 2020
@RobThree
Fix concurrency issue (see PR #23). Upped version.
f181c1d
@RobThree
Copy link
Owner

RobThree commented May 6, 2020

2.4.0
@rmandvikar rmandvikar mentioned this pull request Feb 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@larrynung @RobThree @skylinelarry