Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Rate app on playstore #1837

Merged
philipbrito merged 10 commits into from
Nov 14, 2018
Merged

[NEW] Rate app on playstore #1837

philipbrito merged 10 commits into from
Nov 14, 2018

Conversation

@GOVINDDIXIT
Copy link
Contributor

@GOVINDDIXIT GOVINDDIXIT commented Nov 5, 2018 •
edited
Loading

@RocketChat/android

Closes #1831

This feature will surely improve the app ratings at playstore as many user having good experience with the app are too lazy to rate app manually.

##GIF
gif-181109_232337
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Nov 5, 2018 •
edited
Loading

@rafaelks @luciofm @filipedelimabrito pls review
This is my first PR here can anyone tell me how things goes here
@GOVINDDIXIT GOVINDDIXIT mentioned this pull request Nov 7, 2018
Merged
@philipbrito
Copy link
Contributor

philipbrito commented Nov 8, 2018

@GOVINDDIXIT Could you please fix the conflicting files?
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Nov 8, 2018

Sure wil do
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Nov 9, 2018

@filipedelimabrito pls review
philipbrito
philipbrito suggested changes Nov 10, 2018
View reviewed changes
philipbrito
philipbrito suggested changes Nov 10, 2018
View reviewed changes
@philipbrito philipbrito changed the title feat: rate app on playstore Nov 10, 2018
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Nov 10, 2018 •
edited
Loading

updated, @filipedelimabrito pls review
philipbrito
philipbrito suggested changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOVINDDIXIT Could you also fix the conflicts here?
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Nov 13, 2018

updated, @filipedelimabrito pls review
philipbrito
philipbrito suggested changes Nov 14, 2018
View reviewed changes
@GOVINDDIXIT
Copy link
Contributor Author

GOVINDDIXIT commented Nov 14, 2018

@filipedelimabrito PR is completed from my side. Is anything missing?
@philipbrito
Copy link
Contributor

philipbrito commented Nov 14, 2018

Nothing is missing @GOVINDDIXIT 🎉
Let's merge that.
philipbrito
philipbrito approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution!
@philipbrito philipbrito merged commit 40353ae into RocketChat:develop Nov 14, 2018
@rafaelks rafaelks added this to the 3.2.0 milestone Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🎉 feature

4 participants

@GOVINDDIXIT @CLAassistant @philipbrito @rafaelks