This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Chat Details #1854
Merged
[NEW] Chat Details #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@samrmur Amazing, thank you! @filipedelimabrito is going to review your PR! 👍 |
Contributor
|
The app is crashing for me on the first start... does it work fine for you? |
Contributor
Author
|
Application seems to be working fine for me. I'll update this PR and fix the most recent conflict shortly. |
Contributor
Author
|
@rafaelks updated |
Contributor
|
@samrmur Do you mind updating the app again? We'll make sure to review your PR asap. |
Contributor
|
App still doesn't open for me... crashes right after I open. |
philipbrito
reviewed
Nov 28, 2018
app/src/main/java/chat/rocket/android/chatdetails/di/ChatDetailsFragmentModule.kt
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/di/ChatDetailsFragmentProvider.kt
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/di/ChatDetailsModule.kt
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/presentation/ChatDetailsNavigator.kt
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/presentation/ChatDetailsPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatdetails/viewmodel/ChatDetailsViewModel.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Closes #835
PR Info
Adds the capability of viewing a chat room's information. This works for both subscribed and unsubscribed rooms.
Information that can be viewed:
Note: Could not find all icons that were shown in mock. Can implement those if available.
Screenshot
