Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@philipbrito
Copy link
Contributor

@philipbrito philipbrito commented Dec 12, 2018

Closes #1908 and #1921

This PR also ensures the correct style (look&feel) for our components,

@dabbler011
Copy link
Contributor

@filipedelimabrito app is still crashing.

Here is log for the same :
android.view.InflateException: Binary XML file line #179: Binary XML file line #179: Error inflating class com.google.android.material.chip.ChipGroup Caused by: android.view.InflateException: Binary XML file line #179: Error inflating class com.google.android.material.chip.ChipGroup Caused by: java.lang.reflect.InvocationTargetException at java.lang.reflect.Constructor.newInstance0(Native Method) at java.lang.reflect.Constructor.newInstance(Constructor.java:334) at android.view.LayoutInflater.createView(LayoutInflater.java:647) at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:790) at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:730) at android.view.LayoutInflater.rInflate(LayoutInflater.java:863) at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:824) at android.view.LayoutInflater.inflate(LayoutInflater.java:515) at android.view.LayoutInflater.inflate(LayoutInflater.java:423) at chat.rocket.android.util.extensions.UiKt.inflate(Ui.kt:41) at chat.rocket.android.util.extensions.UiKt.inflate$default(Ui.kt:40) at chat.rocket.android.createchannel.ui.CreateChannelFragment.onCreateView(CreateChannelFragment.kt:70) at androidx.fragment.app.Fragment.performCreateView(Fragment.java:2439) at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManager.java:1460) at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1784) at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManager.java:1852) at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:802) at androidx.fragment.app.FragmentManagerImpl.executeOps(FragmentManager.java:2625) at androidx.fragment.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2411) at androidx.fragment.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2366) at androidx.fragment.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2273) at androidx.fragment.app.FragmentManagerImpl$1.run(FragmentManager.java:733) at android.os.Handler.handleCallback(Handler.java:790) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:164) at android.app.ActivityThread.main(ActivityThread.java:6626) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811) Caused by: java.lang.IllegalArgumentException: This component requires that you specify a valid TextAppearance attribute. Update your app theme to inherit from Theme.MaterialComponents (or a descendant). at com.google.android.material.internal.ThemeEnforcement.checkTextAppearance(ThemeEnforcement.java:170) at com.google.android.material.internal.ThemeEnforcement.obtainStyledAttributes(ThemeEnforcement.java:75) at com.google.android.material.chip.ChipGroup.<init>(ChipGroup.java:113) at com.google.android.material.chip.ChipGroup.<init>(ChipGroup.java:106)

I suppose reason for the above crash is that using chip requires material theme. Is it so?

@philipbrito
Copy link
Contributor Author

@dabbler011 Yes, it is. Probably I forgot to send the commit due to merge changes. Try it now, it should be fine. Thanks for pointing out.

@philipbrito philipbrito merged commit 03a4079 into develop Dec 14, 2018
@philipbrito philipbrito deleted the fix/crash-when-creating-channel branch December 14, 2018 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants