This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Let language setter show the selected locale #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipbrito
suggested changes
Apr 29, 2019
app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@filipedelimabrito Can you please review the changes done here? |
philipbrito
approved these changes
May 6, 2019
Contributor
philipbrito
left a comment
philipbrito
left a comment
There was a problem hiding this comment.
Thanks for sending that PR @HusseinElFeky! 💯
.../main/java/chat/rocket/android/server/infrastructure/SharedPrefsCurrentLanguageRepository.kt
Show resolved
Hide resolved
philipbrito
approved these changes
May 7, 2019
app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
philipbrito
reviewed
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Changes:
Language setter now shows the current selected locale when the dialog is opened.
Screenshots or GIF for the change: