This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT][FIX] Show discussion name / Show server name / Fix avatar not being displayed #2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOVINDDIXIT
added a commit
to GOVINDDIXIT/Rocket.Chat.Android
that referenced
this pull request
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the discussion name not being displayed on the chat list and the avatar not being shown for some servers. It also shows the server name (when not null) on the toolbar and on the list of the servers instead of its URL
Closes #2224
Closes #2116
Depends on RocketChat/Rocket.Chat.Kotlin.SDK#244