Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@hfeky
Copy link
Contributor

@hfeky hfeky commented May 4, 2019

@RocketChat/android

Closes #2220
Closes #2294
Closes #2289

Changes:

  1. Fixed all layout issues when device font is set to larger than default by changing some views' dimensions unit to sp instead of dp and adding android:gravity="center" to some views.
  2. Aligned Take a photo option with the other options in the bottom sheet in message_attachment_options.xml.
  3. Aligned Users option with the other option in the bottom sheet in bottom_sheet_fragment_directory_sorting.xml, and added a margin to the switch to align with the TextView.
  4. Made the arrow in the App Toolbar be auto-mirrored for RTL languages.
  5. Made the text direction be according to the applied locale for all text views in the app.
  6. Corrected some translations in Arabic strings resource file.
  7. Added a padding next to the start drawable of chat name in ChatDetailsFragment.
  8. Fixed typo in layout file bottom_seet_fragment_directory_sorting.xml and renamed it to bottom_sheet_fragment_directory_sorting.xml.
  9. Some other minor code formatting enhancements like indenting lines with 4 spaces instead of 2 or 8, etc.

Screenshots:

At the left is Before, and at the right is After.

Server options (when device font is set to Large):

Server options

Attachment options (Take a photo alignment):

Attachment options

Directory sorting options (Users alignment and switch position):

Directory sorting options

Chat details (chat name padding):

Chat details

Chat details in RTL languages (toolbar arrow and text direction):

Chat details RTL

Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good improvements made here! Thank you very much @HusseinElFeky ! 💯 ❤️

@philipbrito philipbrito merged commit aa04734 into RocketChat:develop May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.