Skip to content

Fix deprecated nullable parameter warning in generate() method #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AskinSavascisi wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix deprecated nullable parameter warning in generate() method #317

AskinSavascisi wants to merge 1 commit into from

Conversation

@AskinSavascisi
Copy link

@AskinSavascisi AskinSavascisi commented Feb 2, 2025

This PR fixes a PHP 8.1+ deprecation warning by explicitly marking the $filename parameter as nullable (?string).
@AskinSavascisi
Update Generator.php
15bbb97 
Fix deprecated nullable parameter warning for generate() method in PHP 8.1+
@ultrono
Copy link

ultrono commented Apr 19, 2025

As this is a package I use I created a fork at https://github.com/f9webltd/simple-qrcode, which includes this and other none merged, important PRs 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@AskinSavascisi @ultrono