-
Notifications
You must be signed in to change notification settings - Fork 54
Adding support for EF Core 6 and .Net 6.0 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ivate nuget repo and so if you want to merge it with the main version, that version could be 3.0.1 non dev.
|
Hello, thank you for opening a PR to upgrade the library to target both The approach of this PR is more suitable since it keeps the support of To solve that, you could update the pipeline file and add the |
|
Alright, all tests have passed. I've updated the pipeline to work with net6.0, and the sample project targets now both net5, and net6. I've also fixed the small typo found in #33, might as well do it at the same time without another pr just for a typo. |
|
Hello, tested on our side with .NET 6, Npgsql provider 6.0, fixed IV. |

I've added project references in the .csproj files:
src/EntityFrameworkCore.DataEncryption/EntityFrameworkCore.DataEncryption.csprojto allow for multiple target platforms, including .net standard 2.0, .net 5.0 and .net 6.0.I've done the same on the
test/EntityFrameworkCore.DataEncryption.Test/EntityFrameworkCore.DataEncryption.Test.csprojfile to allow for them to work with the new version of .net and the new ef core, as well as the previous ones.After doing these changes, I ran the tests and they all passed with flying colors in both .net 5.0 and .net 6.0. I couldn't test on .net core 3.1 since the tests use features that are not available in c#8.0.
Finally I incremented the version to 3.0.1-dev so that you could after increment to 3.0.1 with the new changes, and once you've looked over the changes and agreed with them, as well made sure that it won't break support for older versions of EF core (which it shouldn't).