Skip to content

Conversation

@canix1
Copy link

@canix1 canix1 commented Dec 1, 2025

Updated required .NET to 4.7.2

Description

Updated required .NET to 4.7.2, current mentioning of .Net 4.6.2 does not meet the requirements.

Motivation and Context

If this requirement for .NET 4.7.2 is not followed, SharpHound fails with:
"|ERROR|The .Net Runtime is not compatible with SharpHound. Please update to .Net 4.7.2."

How Has This Been Tested?

On a Windows System, Windows Server 2016, with the default .Net 4.6.2.
SharpHound 2.8.0
Exectution fails.

Install .NET to 4.7.2.

Execution works

Screenshots (if appropriate):

image ## Types of changes
  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Documentation
    • Updated minimum .NET framework requirement from 4.6.2 to 4.7.2 in project requirements.

✏️ Tip: You can customize this high-level summary in your review settings.

Updated required .NET to 4.7.2
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

Documentation updated to reflect the .NET target framework version change from 4.6.2 to 4.7.2 in the Requirements section of README.md.

Changes

Cohort / File(s) Summary
Documentation
README.md
Updated .NET target framework version requirement from 4.6.2 to 4.7.2 in the Requirements section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

enhancement

Suggested reviewers

  • ktstrader
  • rvazarkar

Poem

🐰 A version bump, so neat and clean,
From 4.6.2 to 4.7, serene,
The README now reflects our way,
Updated docs for a brighter day! 📝✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly reflects the main change in the pull request: updating the documented .NET framework requirement from 4.6.2 to 4.7.2.
Description check ✅ Passed The pull request description includes all required template sections with substantial content: comprehensive description, clear motivation/context with error message, detailed testing methodology, appropriate type selection, and relevant checklist items completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed84a79 and 3a7e6ed.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🔇 Additional comments (2)
README.md (2)

28-33: Remove duplicate "# SharpHound" heading and build instructions at lines 28–33.

Lines 28–33 contain a misplaced top-level heading and duplicate build instructions that are already documented in the "Compile Instructions" section (lines 15–22). The H1 heading at line 28 breaks the document hierarchy and should be removed along with the duplicate code block.


26-26: Approved: Documentation correctly reflects actual .NET 4.7.2 requirement.

The update to line 26 is accurate and consistent with the codebase. The TargetFramework in Sharphound.csproj is already set to net472, and the runtime version check in src/Sharphound.cs correctly enforces .NET 4.7.2 (checking for Release value 461808) with the corresponding error message. The documentation was outdated and this change aligns it with the actual requirement already implemented in the code.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant