fix(agent): bound generate_scene retries per page - #1319
Open
hichipli wants to merge 1 commit into
Open
Conversation
Track consecutive failures for the active stageId and order within one runner run. Allow the initial attempt plus one retry, then block further calls for that target before they reach the generation provider. Reset the budget after a successful generation or a move to another page, preserve existing failure details, and leave unrelated tools unaffected. Add policy, Agent-hook, and runner-wiring regression coverage.
hichipli
marked this pull request as ready for review
August 31, 2026 21:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound repeated
generate_scenefailures for the same page within one server-workbench run. The initial generation and one retry may execute; further consecutive calls for the samestageId + orderare rejected before reaching the generation provider.Related Issues
Fixes #1308.
Changes
stageId + order)Type of Change
Verification
Steps to reproduce / test
What you personally verified
Evidence
pnpm check && pnpm lint && npx tsc --noEmit)Checklist