Skip to content

fix(solid-query): forward generic parameters in deprecated type aliases#10093

Open
2wheeh wants to merge 3 commits intoTanStack:mainfrom
2wheeh:fix/generic-create
Open

fix(solid-query): forward generic parameters in deprecated type aliases#10093
2wheeh wants to merge 3 commits intoTanStack:mainfrom
2wheeh:fix/generic-create

Conversation

@2wheeh
Copy link

@2wheeh 2wheeh commented Feb 4, 2026

🎯 Changes

Fix deprecated type aliases in @tanstack/solid-query that were missing generic parameter forwarding.

Before:

type CreateQueryResult = UseQueryResult // generics lost!

After:

export type {
    /** @deprecated Use UseQueryResult instead */
    UseQueryResult as CreateQueryResult, // generics preserved
} from './types'

This fixes type inference for libraries still using the Create* APIs (e.g., @wagmi/solid).

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.

Summary by CodeRabbit

  • Refactor
    • Consolidated and simplified internal type exports while preserving full backward compatibility with existing public types and deprecated aliases.
  • Bug Fix
    • Fixed forwarding of generic parameters in deprecated type aliases to prevent type-resolution issues.
  • Chores
    • Added a changeset entry to trigger a patch release.
@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: 4317a65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tanstack/solid-query Patch
@tanstack/solid-query-devtools Patch
@tanstack/solid-query-persist-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Consolidated deprecated/compatibility type aliases in packages/solid-query/src/index.ts by moving them into the existing export type re-export block from ./types; public API surface unchanged.

Changes

Cohort / File(s) Summary
Solid Query exports
packages/solid-query/src/index.ts
Removed locally declared deprecated type aliases and re-exposed them as compatibility aliases within the unified export type { ... } from './types' block (14 aliases consolidated).
Changeset
.changeset/fix-solid-query-deprecated-types.md
Added a changeset entry indicating a patch to forward generic parameters in the deprecated type aliases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

package: solid-query

Suggested reviewers

  • TkDodo

Poem

🐇 I hopped through types with nimble paws,

Tidied aliases without a pause,
Moved them home, one tidy stack,
Exports neat — no lines to track,
A gentle hop, and then applause!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing generic parameter forwarding in deprecated type aliases for solid-query, which is the core purpose of the PR.
Description check ✅ Passed The description follows the template structure, includes clear before/after examples of the change, explains the motivation, and confirms all checklist items are completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@2wheeh
Copy link
Author

2wheeh commented Feb 11, 2026

@birkskyum Hi, would you have a look at this? it's a simple fix for the regression from create* => use* migration (#8950)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant