feat: Add NVIDIA NIM provider support with intelligent model filtering and …#619
Open
svashisth wants to merge 2 commits intoTauricResearch:mainfrom
Open
feat: Add NVIDIA NIM provider support with intelligent model filtering and …#619svashisth wants to merge 2 commits intoTauricResearch:mainfrom
svashisth wants to merge 2 commits intoTauricResearch:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for NVIDIA (NIM) as an LLM provider, integrating it into the existing OpenAI-compatible client framework. The changes include updates to environment configuration, documentation, and CLI utilities for dynamic model fetching and selection. Comprehensive unit tests for the NVIDIA provider and its model filtering logic are also provided. Feedback identifies a potential crash in the CLI selection logic when a user cancels a prompt and suggests centralizing the hardcoded API endpoint to improve maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tests