remake of fixes PR #169
remake of fixes PR #169
Conversation
WalkthroughThe changes update entity and item configurations for NTPD and Mercenary roles. Telecrystal values and item costs are increased, item descriptions and availability are revised, and certain species (Plasmaman) are now blacklisted from spawning as specific humanoid roles. Naming conventions and starting gear for Mercenaries are also adjusted. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Resources/Prototypes/_Arc/Entities/Structures/Walls/Catalog/uplink_NTPD_catalog.yml (1)
124-163: Deception tool costs updated and pen TODO noted.
Telecrystal costs for stealth box (25 TC), chameleon projector (35 TC), and decoy disk (5 TC) have been adjusted. The NTPD pen entry is commented out with a TODO to reimplement—consider filing an issue or removing dead code if it won’t return soon.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Resources/Prototypes/_Arc/Entities/Objects/Specific/NTPD/ntpd.yml(1 hunks)Resources/Prototypes/_Arc/Entities/Structures/Walls/Catalog/uplink_NTPD_catalog.yml(18 hunks)Resources/Prototypes/_Arc/Ghostroles/humanoid.yml(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Test Packaging
🔇 Additional comments (13)
Resources/Prototypes/_Arc/Entities/Objects/Specific/NTPD/ntpd.yml (1)
29-29: Suffix update is correct.
The suffix "300 TC" now accurately reflects the new Telecrystal capacity.Resources/Prototypes/_Arc/Entities/Structures/Walls/Catalog/uplink_NTPD_catalog.yml (7)
4-34: Weaponry costs updated to match new Telecrystal inflation.
TheTelecrystalvalues for SMG (80 TC), L6 SAW (150 TC), and the energy sword (40 TC) have been increased and remain within the 300 TC starting balance.
37-76: Explosives pricing adjusted.
Grenade, flash grenade, C4, and shrapnel grenade costs have been updated (20 TC, 5 TC, 10 TC, 20 TC respectively) to align with the new uplink economy.
79-98: Ammunition costs revised.
Magazine costs for .30 rifle (5 TC) and L6 SAW box (15 TC) now reflect increased Telecrystal inflation.
101-120: Chemical kit and medkit pricing updated.
Starter chemistry kit and combat medkit costs have been raised to 20 TC each, in line with uplink currency changes.
167-196: Disruption device costs increased.
Pricing for EMAG (20 TC), Doorjack (30 TC), and radio jammer (20 TC) now aligns with the updated economic model.
201-250: Implanter pricing updated.
Telecrystal costs for storage, bike horn, freedom, scram, and death acidifier implanters have been raised (40 TC, 20 TC, 25 TC, 30 TC, 5 TC respectively) to match the uplink currency shift.
255-274: Wearables pricing revised.
Thieving gloves (20 TC) and NTPD magboots (10 TC) costs have been updated to align with overall uplink inflation.Resources/Prototypes/_Arc/Ghostroles/humanoid.yml (5)
23-23: Blacklisting Plasmaman from NTPD Operator.
AddingPlasmamanto the species blacklist ensures this role cannot spawn as Plasmaman, aligning with the intended design.
76-76: Blacklisting Plasmaman from NTPD Agent.
IncludingPlasmamanprevents this species from spawning as an NTPD agent, matching the operator configuration.
113-114: Standardize Mercenary naming segments.
Name segments were updated to lowercasenames_firstandnames_lastfor both the Mercenary entity and its settings, improving consistency across ghostroles.Also applies to: 130-131
123-124: Blacklisting Plasmaman from Mercenary.
AddingPlasmamanto theMERCSettings.speciesBlacklistcorrectly excludes this species from the Mercenary role.
143-143: Add web vest to Mercenary gear.
TheClothingOuterVestWebMercaddition ensures Mercenaries have proper outer clothing. Please verify that this prototype ID exists to avoid spawn-time errors.
nothing else references this so it should be fine
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
both of these fails seem to be entirely unrelated |
Description
remake of #162
blacklists plasmamen from merc and NTPD spawns
changes merc names to normal names instead of whatever the hell is going on in here
gives mercs a web vest because they have an air tank in suit storage but no outer clothing
NTPD uplink now has a proper TC amount (+ pricing) following the telecrystal inflation (300TC)
Changelog
🆑