Skip to content

Conversation

@roblaszczak
Copy link
Member

Motivation / Background

Logging context cancellation inthe handler doesn't give any value, and it adds noise to logs.

Detail

Checklist

The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:

  • I wrote tests for the changes. - doesn't make sense here
  • All tests are passing.
    • If you are testing a Pub/Sub, you can start Docker with make up.
    • You can start with make test_short for a quick check.
    • If you want to run all tests, use make test.
  • Code has no breaking changes.
  • (If applicable) documentation on watermill.io is updated.
Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com>
@roblaszczak roblaszczak merged commit a0a845c into master Apr 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants