Skip to content

Conversation

@prschulz
Copy link
Contributor

Got some code for us? Awesome 🎊!

Please take a minute to explain the change you're making:

  • Why are you making it?
    To address Linear issue NY-863, which highlighted that publishers need to manually calculate the net change in paid members from the "New" and "Cancelled" values in the growth chart tooltip.
  • What does it do?
    This PR adds a "Net change" line to the tooltip on the paid members change chart. It calculates the sum of "New" and "Cancelled" members for the period and displays it with appropriate + or - formatting.
  • Why is this something Ghost users or developers need?
    Ghost users (publishers) will gain immediate insight into their net subscriber growth or loss without needing to perform manual calculations, making the chart more efficient and user-friendly for understanding member trends.

Please check your PR against these items:

  • I've read and followed the Contributor Guide
  • I've explained my change
  • I've written an automated test to prove my change works

We appreciate your contribution! 🙏


Linear Issue: NY-863

Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Dec 10, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/NY-863-add-net-change-tooltip-0f30

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cmraible cmraible added the deploy-to-staging Optionally deploy PR to staging label Dec 10, 2025
@cmraible cmraible self-requested a review December 10, 2025 19:51
Co-authored-by: peter <peter@ghost.org>
@peterzimon peterzimon force-pushed the cursor/NY-863-add-net-change-tooltip-0f30 branch from 8b7cb06 to 5a02c65 Compare December 18, 2025 14:29
@peterzimon peterzimon self-requested a review December 18, 2025 14:43
Copy link
Contributor

@peterzimon peterzimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-to-staging Optionally deploy PR to staging

5 participants