Skip to content

Added missing Polish translations #25710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomododi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added missing Polish translations #25710

tomododi wants to merge 2 commits into from

Conversation

@tomododi
Copy link

@tomododi tomododi commented Dec 13, 2025 •
edited by cursor bot
Loading

Added 31 missing Polish translations.

Note

Completes missing Polish strings across comments, email/auth notifications, and portal UI in three locale files.

  • i18n (Polish pl):
    • ghost/i18n/locales/pl/ghost.json:
      • Add translations for email/auth strings (e.g., New comment on {postTitle}, Sign in now, Sign in to {siteTitle} with code {otc}, reply notifications, unsubscribe/view comments, verification code variants, unsubscribe link notice).
    • ghost/i18n/locales/pl/portal.json:
      • Add translations for auth/verification flows and errors (e.g., email sent notice, Code, Enter code above, invalid/failed verification, Verifying..., "not accepting donations", "your inbox").
    • ghost/i18n/locales/pl/comments.json:
      • Add translations for comment UI labels (Add your expertise, Best, Newest, Oldest).

Written by Cursor Bugbot for commit 7c1b5bb. This will update automatically on new commits. Configure here.
@tomododi
Added missing Polish translations. Translated 31 missing strings acro…
7c1b5bb 
…ss comments.json, ghost.json, and portal.json
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 13, 2025 •
edited
Loading

Walkthrough

This pull request updates Polish language translations across three locale files in the Ghost i18n directory. The changes populate previously empty translation entries in comments.json, ghost.json, and portal.json with appropriate Polish text. Updates include translations for comment-related strings, authentication messages, notification texts, and portal interface elements. No structural changes, logic modifications, or behavioral alterations are introduced—only translation data content updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

Areas for attention:

  • Verify Polish translation accuracy and grammatical consistency across all three locale files
  • Check JSON syntax validity to ensure no formatting errors were introduced
  • Confirm placeholder variables (e.g., {submittedEmailOrInbox}, {postTitle}, {siteTitle}) are preserved correctly in translated strings
  • Cross-reference translated strings for terminology consistency (e.g., consistent use of Polish terms across different contexts)

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely summarizes the main change: adding missing Polish translations across multiple locale files.
Description check ✅ Passed The description is clearly related to the changeset, providing specific details about which translation keys were added across three locale files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3004c11 and eddefb2.

📒 Files selected for processing (3)
  • ghost/i18n/locales/pl/comments.json (2 hunks)
  • ghost/i18n/locales/pl/ghost.json (1 hunks)
  • ghost/i18n/locales/pl/portal.json (8 hunks)
🧰 Additional context used
🧠 Learnings (15)
📓 Common learnings 
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Applies to ghost/i18n/locales/en/ghost.json : Add UI translations to `ghost/i18n/locales/en/ghost.json` for Admin UI features

Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 0
File: :0-0
Timestamp: 2025-05-20T21:08:21.026Z
Learning: In the Ghost project, translation files (ghost/i18n/locales/*/*.json) commonly have blank values for translations, and this is normal behavior that should not be flagged in reviews. These empty translations will be filled in separate PRs.

Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 23070
File: ghost/i18n/locales/hu/comments.json:45-45
Timestamp: 2025-04-30T16:27:03.542Z
Learning: In the Ghost project, new translation string keys are intentionally added with empty values initially and will be translated in a separate PR. Do not report missing translations for entirely new string additions.

Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 22175
File: ghost/i18n/locales/pt-BR/portal.json:18-18
Timestamp: 2025-02-12T20:09:12.731Z
Learning: In the Ghost project, new translation keys are first added with empty string values, and the actual translations are added later in separate PRs to maintain better organization of translation work.

Learnt from: kevinansfield
Repo: TryGhost/Ghost PR: 25118
File: apps/portal/src/App.js:719-719
Timestamp: 2025-10-09T14:16:58.334Z
Learning: In Ghost Portal (apps/portal), avoid suggesting changes to translation strings (wrapped in `t()`) unless directly related to the PR's primary objective, as changing them invalidates existing translations and creates unnecessary churn. If a typo or improvement is found in a translation string, it should be fixed across all instances in a dedicated PR.

Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Applies to ghost/i18n/locales/en/{portal,comments,signup-form,search}.json : Add UI translations to namespace-specific files in `ghost/i18n/locales/en/` for public UI apps (portal.json for Portal, comments.json for Comments UI, etc.)

Learnt from: sagzy
Repo: TryGhost/Ghost PR: 24673
File: ghost/i18n/lib/i18n.js:34-35
Timestamp: 2025-11-24T11:12:15.712Z
Learning: In the Ghost i18n package (ghost/i18n/lib/i18n.js), changing existing locale codes requires backwards compatibility handling for users who have already configured those locales. Such changes should be done in a separate PR with migration logic rather than included in feature PRs.

Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 0
File: :0-0
Timestamp: 2025-01-29T15:27:29.391Z
Learning: When reviewing translation files in ghost/i18n/locales, translators should only modify the translated values and must not change the keys or placeholder styles (e.g., %%{status}%%, {site}, etc.) as they serve specific purposes like Mailgun string replacement.

Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Centralized i18n translations should be maintained in `ghost/i18n/locales/{locale}/{namespace}.json` files with 60+ supported locales

Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 21982
File: ghost/i18n/locales/hu/portal.json:207-207
Timestamp: 2025-02-15T16:00:03.347Z
Learning: In Hungarian translations for Ghost, ensure that all variables like {{title}} are preserved in the translated strings and not omitted.
📚 Learning: 2025-11-25T14:28:50.351Z 
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Applies to ghost/i18n/locales/en/{portal,comments,signup-form,search}.json : Add UI translations to namespace-specific files in `ghost/i18n/locales/en/` for public UI apps (portal.json for Portal, comments.json for Comments UI, etc.)

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/comments.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-11-25T14:28:50.351Z 
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Applies to ghost/i18n/locales/en/ghost.json : Add UI translations to `ghost/i18n/locales/en/ghost.json` for Admin UI features

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/comments.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-05-20T21:08:21.026Z 
Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 0
File: :0-0
Timestamp: 2025-05-20T21:08:21.026Z
Learning: In the Ghost project, translation files (ghost/i18n/locales/*/*.json) commonly have blank values for translations, and this is normal behavior that should not be flagged in reviews. These empty translations will be filled in separate PRs.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/comments.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-01-29T15:27:29.391Z 
Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 0
File: :0-0
Timestamp: 2025-01-29T15:27:29.391Z
Learning: When reviewing translation files in ghost/i18n/locales, translators should only modify the translated values and must not change the keys or placeholder styles (e.g., %%{status}%%, {site}, etc.) as they serve specific purposes like Mailgun string replacement.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/comments.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-11-24T11:12:15.712Z 
Learnt from: sagzy
Repo: TryGhost/Ghost PR: 24673
File: ghost/i18n/lib/i18n.js:34-35
Timestamp: 2025-11-24T11:12:15.712Z
Learning: In the Ghost i18n package (ghost/i18n/lib/i18n.js), changing existing locale codes requires backwards compatibility handling for users who have already configured those locales. Such changes should be done in a separate PR with migration logic rather than included in feature PRs.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/comments.json
📚 Learning: 2025-04-30T16:27:03.542Z 
Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 23070
File: ghost/i18n/locales/hu/comments.json:45-45
Timestamp: 2025-04-30T16:27:03.542Z
Learning: In the Ghost project, new translation string keys are intentionally added with empty values initially and will be translated in a separate PR. Do not report missing translations for entirely new string additions.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/comments.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-02-15T16:00:03.347Z 
Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 21982
File: ghost/i18n/locales/hu/portal.json:207-207
Timestamp: 2025-02-15T16:00:03.347Z
Learning: In Hungarian translations for Ghost, ensure that all variables like {{title}} are preserved in the translated strings and not omitted.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-10-09T14:16:58.334Z 
Learnt from: kevinansfield
Repo: TryGhost/Ghost PR: 25118
File: apps/portal/src/App.js:719-719
Timestamp: 2025-10-09T14:16:58.334Z
Learning: In Ghost Portal (apps/portal), avoid suggesting changes to translation strings (wrapped in `t()`) unless directly related to the PR's primary objective, as changing them invalidates existing translations and creates unnecessary churn. If a typo or improvement is found in a translation string, it should be fixed across all instances in a dedicated PR.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-11-25T14:28:50.351Z 
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Centralized i18n translations should be maintained in `ghost/i18n/locales/{locale}/{namespace}.json` files with 60+ supported locales

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
📚 Learning: 2025-07-29T05:18:41.313Z 
Learnt from: kasnol
Repo: TryGhost/Ghost PR: 24523
File: ghost/i18n/locales/zh-Hant/ghost.json:25-26
Timestamp: 2025-07-29T05:18:41.313Z
Learning: In Ghost's Traditional Chinese localization, when source English text is modified (such as removing words like "safely"), the corresponding Chinese translations should be updated to match. For example, if "safely" is removed from English security-related messages, the corresponding "放心" should also be removed from the Chinese translation to maintain translation accuracy.

Applied to files:

  • ghost/i18n/locales/pl/ghost.json
📚 Learning: 2025-07-29T05:08:05.874Z 
Learnt from: kasnol
Repo: TryGhost/Ghost PR: 24523
File: ghost/i18n/locales/zh-Hant/comments.json:45-46
Timestamp: 2025-07-29T05:08:05.874Z
Learning: For Traditional Chinese localization in Ghost's comments.json, "Oldest" should be translated as "最早" (not "最初") when used in comment sorting selectors, as "最早" better conveys the temporal sorting context.

Applied to files:

  • ghost/i18n/locales/pl/comments.json
📚 Learning: 2025-07-29T04:57:10.163Z 
Learnt from: kasnol
Repo: TryGhost/Ghost PR: 24523
File: ghost/i18n/locales/zh-Hant/comments.json:11-11
Timestamp: 2025-07-29T04:57:10.163Z
Learning: In Ghost's Traditional Chinese localization, the "Add your expertise" label appears as a link in comments when expertise is not yet provided, specifically to request additional professional background information from commenters. The translation should reflect this context of inviting additional information rather than just adding new information.

Applied to files:

  • ghost/i18n/locales/pl/comments.json
📚 Learning: 2025-02-12T20:09:12.731Z 
Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 22175
File: ghost/i18n/locales/pt-BR/portal.json:18-18
Timestamp: 2025-02-12T20:09:12.731Z
Learning: In the Ghost project, new translation keys are first added with empty string values, and the actual translations are added later in separate PRs to maintain better organization of translation work.

Applied to files:

  • ghost/i18n/locales/pl/comments.json
  • ghost/i18n/locales/pl/portal.json
📚 Learning: 2025-02-12T20:23:47.777Z 
Learnt from: cathysarisky
Repo: TryGhost/Ghost PR: 22175
File: ghost/i18n/locales/lt/portal.json:16-16
Timestamp: 2025-02-12T20:23:47.777Z
Learning: When reviewing localization changes, verify the actual history of translations before flagging potential deletions. Empty translation strings may be intentional placeholders rather than deleted content.

Applied to files:

  • ghost/i18n/locales/pl/comments.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cursor Bugbot
🔇 Additional comments (3)
ghost/i18n/locales/pl/comments.json (1)

11-11: Polish translations for comment sorting and profile labels look good.

The four comment-related strings are now properly translated to Polish. The translations align well with existing patterns in the file and correctly convey the intent of the English originals.

Also applies to: 17-17, 45-46

ghost/i18n/locales/pl/ghost.json (1)

32-35: Polish translations for sign-in, notifications, and welcome messages are well executed.

All variable placeholders—{postTitle}, {siteTitle}, {otc}, {email}, {siteDomain}, {profileUrl}—are preserved correctly throughout the translations. The Polish phrasing is natural and maintains consistency with the surrounding translations in the file.

Also applies to: 42-42, 44-44, 46-47, 55-55, 58-58, 61-61, 64-65, 71-71

ghost/i18n/locales/pl/portal.json (1)

21-21: Portal UI translations to Polish are clear and well-integrated.

All eight translation entries are properly localized, including the variable placeholder {submittedEmailOrInbox} on line 21, which is correctly preserved. The translations maintain consistency with existing portal UI strings and will provide a cohesive user experience for Polish speakers.

Also applies to: 42-42, 69-69, 86-86, 105-105, 177-177, 200-200, 219-219

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.
@cathysarisky cathysarisky self-assigned this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects:i18n

2 participants

@tomododi @cathysarisky