Skip to content

Conversation

@kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Dec 18, 2025

Changelog for v1.2.6 -> 1.3.0:
  - 3df0e8c3f7
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Walkthrough

This pull request performs a version bump of the comments-ui package from 1.2.6 to 1.3.0. The change updates the package version in the comments-ui package.json manifest file and correspondingly updates the comments-ui dependency reference in the Ghost core configuration defaults file from version 1.2 to 1.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Rationale: Both changes are simple, homogeneous version number updates in configuration files with no functional logic, structural modifications, or behavioral changes. The updates are consistent with standard version management practices and require minimal verification.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and specifically describes the main change: releasing version 1.3.0 of the @tryghost/comments-ui package, which directly matches the version bumps in both modified files.
Description check ✅ Passed The description provides relevant context by referencing the changelog for the version bump (v1.2.6 -> v1.3.0) and links to the actual change commit, which is related to the pull request's purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-comments

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17638a2 and 0cbfd8d.

📒 Files selected for processing (2)
  • apps/comments-ui/package.json (1 hunks)
  • ghost/core/core/shared/config/defaults.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/comments-ui/{package.json,**/.github/workflows/**,**/playwright.config.{ts,js},**/*.{sh,bash}}

📄 CodeRabbit inference engine (apps/comments-ui/.cursor/rules/playwright-e2e.mdc)

Set PLAYWRIGHT_REPORTER=list environment variable when running Playwright e2e tests as an AI agent for better parsing

Files:

  • apps/comments-ui/package.json
🧠 Learnings (4)
📓 Common learnings
Learnt from: cmraible
Repo: TryGhost/Ghost PR: 24658
File: ghost/admin/package.json:3-3
Timestamp: 2025-08-12T18:33:15.524Z
Learning: In Ghost's admin package.json, third-party packages like ember-cli-postcss, ember-exam, and ember-power-select have their own independent versioning schemes that are unrelated to Ghost's version numbers. Version number coincidences between Ghost versions and these packages should not trigger update suggestions.
📚 Learning: 2025-08-12T18:33:15.524Z
Learnt from: cmraible
Repo: TryGhost/Ghost PR: 24658
File: ghost/admin/package.json:3-3
Timestamp: 2025-08-12T18:33:15.524Z
Learning: In Ghost's admin package.json, third-party packages like ember-cli-postcss, ember-exam, and ember-power-select have their own independent versioning schemes that are unrelated to Ghost's version numbers. Version number coincidences between Ghost versions and these packages should not trigger update suggestions.

Applied to files:

  • apps/comments-ui/package.json
  • ghost/core/core/shared/config/defaults.json
📚 Learning: 2025-02-06T10:30:53.440Z
Learnt from: allouis
Repo: TryGhost/Ghost PR: 22127
File: .github/scripts/release-apps.js:72-74
Timestamp: 2025-02-06T10:30:53.440Z
Learning: In the Ghost repository, the path to defaults.json is correctly structured as 'ghost/core/core/shared/config/defaults.json' with an intentional double 'core' in the path.

Applied to files:

  • ghost/core/core/shared/config/defaults.json
📚 Learning: 2025-11-25T14:28:50.351Z
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:28:50.351Z
Learning: Public UI apps (Portal, Comments UI, Signup Form, Sodo Search, Announcement Bar) should be built as UMD bundles for CDN distribution

Applied to files:

  • ghost/core/core/shared/config/defaults.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Setup
  • GitHub Check: Build & Push Docker Image
🔇 Additional comments (2)
apps/comments-ui/package.json (1)

3-3: LGTM!

The version bump from 1.2.6 to 1.3.0 is correctly applied for the release.

ghost/core/core/shared/config/defaults.json (1)

248-251: LGTM!

The version update from 1.2 to 1.3 correctly aligns with the package.json version bump to 1.3.0. The major.minor format used here with the ~{version} URL template is consistent with the other public UI apps in this configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield kevinansfield enabled auto-merge (squash) December 18, 2025 14:33
@github-actions
Copy link
Contributor

React E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-react -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
1 similar comment
@github-actions
Copy link
Contributor

React E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-react -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
@github-actions
Copy link
Contributor

Ember E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-ember -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
@github-actions
Copy link
Contributor

React E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-react -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
@github-actions
Copy link
Contributor

Ember E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-ember -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
1 similar comment
@github-actions
Copy link
Contributor

Ember E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-ember -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
@github-actions
Copy link
Contributor

React E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-react -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
@github-actions
Copy link
Contributor

Ember E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-ember -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
@github-actions
Copy link
Contributor

React E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 20340421252 -n playwright-report-react -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants