Skip to content

feat(workbench): content management — delete KB, delete/edit wiki pages - #198

Merged
KylinMountain merged 8 commits into
mainfrom
feat/workbench-content-management
Jul 21, 2026
Merged

feat(workbench): content management — delete KB, delete/edit wiki pages#198
KylinMountain merged 8 commits into
mainfrom
feat/workbench-content-management

Conversation

@KylinMountain

@KylinMountain KylinMountain commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Completes the Knowledge Workbench's CRUD story: before this, the web UI could only read the wiki (browse). This branch adds delete a KB, delete a wiki page, and edit a wiki page — backend endpoints + CLI + UI — reusing the existing lint/mutation machinery so references degrade cleanly.

Backend

  • POST /api/v1/kb/delete (+ openkb delete-kb NAME): physical, irreversible KB deletion with a type-the-name confirmation (re-checked server-side). Unregisters from the global registry; tolerates a ghost entry (registry row whose directory was removed by hand). delete_kb/unregister_kb live in a new openkb/kb_admin.py (keeps config.py under the line gate).
  • POST /api/v1/page/delete: delete a concept/entity page. dry_run first returns the backlink pages whose inbound [[links]] will be demoted to plain text (the impact preview); execute removes the page (under the KB ingest lock), strips its index.md entry, and demotes the now-dangling inbound links.
  • PUT /api/v1/page: edit a concept/entity or summary page's body. The code-managed OKF frontmatter is preserved; dead [[links]] typed by the user are demoted to plain text on save (returned so the UI can warn).
  • POST /api/v1/page/links: outbound + inbound links for the edit panel.
  • GET /api/v1/list already surfaces entities; the page endpoints validate refs to concepts//entities/ (delete) and +summaries/ (edit) only — traversal-safe.

Frontend

  • Delete KB: a Danger Zone in the KB settings sheet (type-the-name confirm); on success it refreshes the sidebar (openkb:reload-kbs) and returns to the KB list.
  • Delete / Edit page: in the reader header — Delete (concept/entity) shows the dry-run impact then confirms; Edit (concept/entity/summary) opens a body editor with an out/in-links panel, a "recompile may overwrite" note, and a demoted-links warning on save. Summaries are editable but not independently deletable (a summary is removed by deleting its source document).

Model

Page type Edit Delete
concept / entity ✅ ✅ (impact preview)
summary ✅ ❌ — delete its source document
index / reports ❌ ❌ (generated)

Review

Two /code-review passes were run against this branch (max, then xhigh); all correctness/concurrency findings were fixed — read-modify-write moved inside the KB ingest lock, page deletion no longer touches AGENTS.md/SCHEMA.md/log.md, edit no longer mis-eats a ----leading body, cross-platform delete_kb (no lock held during rmtree), endpoint OSError handling, and a KB-registry test-isolation bug.

Verification

Backend pytest 1237 passed, mypy/ruff clean, frontend npm run build green (i18n guard: zh/en key sets identical). Manually exercised on a running openkb-web — delete KB, delete/edit concept/entity, edit summary.

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
feat(api): delete a knowledge base (POST /api/v1/kb/delete + openkb d…
2d019b3 
…elete-kb)

Physical, irreversible KB deletion with a type-the-name confirmation.

- config.delete_kb: rmtree the KB directory + unregister it from the global
  registry (known_kbs / kb_aliases / default_kb, via the new unregister_kb).
  Guards against deleting a non-KB path; tolerates a ghost registry entry
  (directory already gone) by just unregistering.
- POST /api/v1/kb/delete: confirm_name must equal kb, re-checked server-side.
  Lives in a new api_kbs_router (sibling of the config/graph/output routers) so
  api.py stays under the 800-line gate; delete_kb self-locks (config lock), no
  create_app closure needed.
- openkb delete-kb NAME: type-the-name prompt (or --yes) then delete.

Tests: endpoint (success + unregister, confirm mismatch, non-KB target) in
test_api.py; config (physical delete + unregister, refuse non-KB, ghost
tolerance) in test_config.py.

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
feat(api): delete a wiki page (POST /api/v1/page/delete) with backlin…
69e1c0b 
…k impact

Delete a concept/entity page and degrade references cleanly instead of leaving
them dangling:

- page_ops.delete_wiki_page: dry_run reports the backlink pages (whose inbound
  [[wikilinks]] would be demoted) without touching anything; execute removes the
  page under the KB ingest lock, strips its index.md entry outright
  (compiler.remove_doc_from_index — the entry is a [[link]] line), and demotes
  the now-dangling inbound [[links]] to plain text in ONLY those backlink pages
  (lint.fix_broken_links restrict_to). The page ref is "section/stem", validated
  to concepts/ or entities/ only (path-traversal-safe).
- New api_pages_router hosts POST /api/v1/page (read — relocated here from
  api.py to keep it under the 800-line gate) + POST /api/v1/page/delete.

Tests: dry-run impact + execute (page gone, inbound link demoted to text, index
entry removed, sibling kept), 404 on missing page, and rejection of unsafe /
non-editable refs.

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
feat(api): edit a wiki page (PUT /api/v1/page) + link context (POST /…
97c8357 
…api/v1/page/links)

- page_ops.edit_wiki_page: replace a concept/entity page's BODY while preserving
  its code-managed OKF frontmatter (type/description/sources) verbatim; any
  frontmatter in the submitted content is dropped. Dead [[wikilinks]] the user
  typed are demoted to plain text on save (OpenKB keeps the wiki broken-link-free)
  and returned as ghosts_stripped so the UI can warn. Atomic write under the KB
  ingest lock.
- page_ops.page_link_context (POST /api/v1/page/links): outbound + inbound links
  for the edit-impact panel. Editing the body does not break either (links are
  path-based), so this is context, not a blocker — the honest impact model.
- PUT /api/v1/page added to api_pages_router.

Tests: edit preserves frontmatter + keeps a resolvable link + demotes a dead one
(reports ghosts_stripped) + replaces the body; 404 on a missing page; links
reports out/backlinks.

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
feat(web): delete a knowledge base from the settings sheet (type-name…
3abcf28 
… confirm)

Adds a Danger Zone section to KbSettingsSheet: a type-the-name confirmation
gates deleteKb() (POST /api/v1/kb/delete); on success KbDetail navigates back
to the KB list. New deleteKb client + kbSettings danger* keys + common cancel
(zh + en, identical key sets).

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
feat(web): in-reader page edit + delete with impact preview (F2/F3)
c4da03f 
For an open concept/entity page, the reader header now shows Edit and Delete:
- Delete: a dry-run first (deletePage dryRun) surfaces the backlink pages whose
  [[links]] will demote to plain text; a red confirm card lists them, then the
  real delete closes the page and refreshes the inventory.
- Edit: a body textarea (frontmatter is preserved server-side), Save via
  PUT /api/v1/page, a links panel (getPageLinks: out/backlinks), a "recompile
  may overwrite" note, and a toast listing any dead links demoted to text.

Adds the deletePage/editPage/getPageLinks wiki clients and kb:pageOps.* locale
keys (zh + en, identical key sets). Build green (i18n guard + tsc + vite).

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
fix(workbench): address code-review findings (content-mgmt correctnes…
6a908b1 
…s + concurrency)

Backend (page_ops / kb_admin / lint):
- delete/edit now do their read-modify-write INSIDE the KB ingest lock and
  re-check the page exists under it: no stale backlink snapshot, no resurrecting
  a concurrently-deleted page, no 500 on a racing unlink (missing_ok=True). [#4,#5,#6]
- delete_kb serializes rmtree under the ingest lock (was fully unlocked). Moved
  delete_kb/unregister_kb into a new openkb/kb_admin.py so config.py drops back
  under the per-file line gate (751 lines). [#1,#15]
- page deletion no longer scans or rewrites lint's _EXCLUDED_FILES
  (AGENTS.md/SCHEMA.md/log.md); fix_broken_links(restrict_to) also refuses them,
  which protects `openkb remove` too. [#2]
- edit_wiki_page treats `content` as the body verbatim — no naive frontmatter
  split that silently dropped a body opening with a '---' block. [#3]
- delete uses the real on-disk stem for the exact-match index-entry removal
  (case-insensitive FS), and adds index.md to the demotion set so a [[target]]
  embedded in another entry's brief no longer dangles. [#7,#9]

API / CLI:
- delete-KB endpoint & CLI can now clean a ghost registry entry (registered name
  whose directory was removed by hand), catch delete_kb's ValueError -> 400, and
  the endpoint is typed `-> KbDeleteResponse`. [#8,#13,E5]

Frontend (KbDetail):
- Deleting a KB dispatches `openkb:reload-kbs` so the sidebar refreshes
  immediately (was stale until a manual reload) — live-test fix.
- Removed the dead `pageReloadSeq` path (editPage always returns content). [#14]

Tests: excluded-doc-untouched, '---'-body preservation, ghost-KB unregister;
non-KB-target test updated to the new resolution model. Backend 1234 passed,
mypy/ruff clean, frontend build green.

Not changed (intentional): pages_linking_to is NOT folded into build_graph (that
excludes explorations/ backlinks) [#10]; the preview+confirm delete inherently
scans per request [#11]; EDITABLE_SECTIONS stays duplicated in the frontend,
which can't import the Python constant [#12].

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
feat(workbench): allow editing summary pages (edit ⊇ delete section s…
a672916 
…ets)

Summaries are compiled markdown like concepts/entities (a recompile regenerates
them), so they are now editable via PUT /api/v1/page. They remain NOT
independently deletable — a summary is removed by deleting its source document.

Split page_ops into EDITABLE_SECTIONS (concepts/entities/summaries) vs
DELETABLE_SECTIONS (concepts/entities); validate_page_ref takes the allowlist.
Frontend ReaderBody gates Edit on canEdit (incl. summaries), Delete on canDelete.

Test: summary editable (frontmatter preserved) + summary delete rejected (400).

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
fix(api): cross-platform delete_kb + endpoint OSError handling (xhigh…
7630640 
… review #1,#2)

- delete_kb no longer holds the ingest lock DURING rmtree (the lock file lives
  inside the KB dir; Windows cannot delete an open file — the prior review-fix
  regressed this). It now takes the lock as a BARRIER (drain + wait out any
  in-flight mutation), releases it, re-checks existence, then rmtrees. [#1]
- delete-KB endpoint maps FileNotFoundError to an idempotent success (a
  concurrent delete already removed the tree) and other OSError to a clean 500
  with a message, instead of an uncaught 500 stack trace. [#2]

Tests: endpoint OSError -> clean 500, FileNotFoundError -> 200 deleted.

Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
@KylinMountain
KylinMountain merged commit a69c7d4 into main Jul 21, 2026
4 checks passed
@KylinMountain
KylinMountain deleted the feat/workbench-content-management branch July 21, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@KylinMountain