fix: get_leaf_nodes KeyError on nodes-less leaf nodes - #453
Open
Manish2102 wants to merge 1 commit into
Open
Conversation
clean_node() deletes the `nodes` key entirely from childless nodes during tree cleanup instead of setting it to an empty list, so get_leaf_nodes()'s direct `structure['nodes']` access raised KeyError on any tree produced by the normal pipeline (VectifyAI#330). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes a crash in pageindex.utils.get_leaf_nodes() when leaf nodes have no nodes key (as produced by the normal list_to_tree() cleanup pipeline described in #330).
Changes:
- Update
get_leaf_nodes()to usestructure.get('nodes')instead of directstructure['nodes']access to avoidKeyErroron leaf nodes missing the key. - Add regression tests covering both missing
nodeskeys and explicit emptynodes: []leaf nodes, plus list-of-trees input handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pageindex/utils.py |
Makes leaf detection tolerant of missing nodes keys to prevent KeyError in normal pipeline output. |
tests/test_utils.py |
Adds regression tests ensuring get_leaf_nodes() handles missing/empty nodes and list inputs correctly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean_node() deletes the
nodeskey entirely from childless nodes during tree cleanup instead of setting it to an empty list, so get_leaf_nodes()'s directstructure['nodes']access raised KeyError on any tree produced by the normal pipeline (#330).