Skip to content

Add checkbox to Settings > Media to control whether to generate JPEG in addition to WebP#537

Merged
felixarntz merged 34 commits intotrunkfrom
enhancement/525-checkbox-multi-mime-setting
Oct 7, 2022
Merged

Add checkbox to Settings > Media to control whether to generate JPEG in addition to WebP#537
felixarntz merged 34 commits intotrunkfrom
enhancement/525-checkbox-multi-mime-setting

Conversation

@mehulkaklotar
Copy link
Member

@mehulkaklotar mehulkaklotar commented Sep 19, 2022

Summary

This PR is dependent on the issue #524 and PR #527

PR introduces

  • WordPress setting generate_webp_and_jpeg -> boolean value
  • Changes default filter output for webp_uploads_upload_image_mime_transforms to image/jpeg and image/webp if the generate_webp_and_jpeg is true

Remaining work(After #524 is merged)

Fixes #525

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.
@mehulkaklotar mehulkaklotar added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Sep 19, 2022
@mehulkaklotar mehulkaklotar added this to the 1.6.0 milestone Sep 19, 2022
Copy link
Member Author

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Changes looks good here. We should add some tests for the new setting.

@mehulkaklotar mehulkaklotar marked this pull request as ready for review October 5, 2022 11:20
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehulkaklotar This is on a good path, some quirks to address though.

@felixarntz felixarntz changed the title Enhancement/525 checkbox multi mime setting Oct 5, 2022
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehulkaklotar One more thing: Please make sure to delete the new option in uninstall.php.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehulkaklotar This is almost good to go now. Left mostly minor suggestions, so there are two quirks (one little tricky) to still address.

mukeshpanchal27 and others added 8 commits October 6, 2022 09:35
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 @mehulkaklotar One small optimization recommendation here, but other than that this is good to go.

mukeshpanchal27 and others added 2 commits October 7, 2022 10:21
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@felixarntz felixarntz merged commit 55213ba into trunk Oct 7, 2022
@felixarntz felixarntz deleted the enhancement/525-checkbox-multi-mime-setting branch October 7, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

3 participants