fix: ensure execution stops after redirects#786
Merged
kasparsd merged 2 commits intoWordPress:masterfrom Feb 13, 2026
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
7 tasks
georgestephanis
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures that code execution stops after calling
wp_safe_redirect()in the two-factor authentication validation functions. Withoutexit(), PHP continues executing code after sending redirect headers, which could lead to security vulnerabilities or unintended behavior.Why?
This follows WordPress best practices and aligns with the existing function documentation that states "wp_safe_redirect() does not exit automatically, and should almost always be followed by a call to
exit;."How?
Add
exit()after calls towp_safe_redirect().Testing Instructions
N/A :-(
Screenshots or screencast
N/A
Changelog Entry