Skip to content

Block Supports: Add text indent to typography supports #10573

Closed
aaronrobertshaw wants to merge 4 commits intoWordPress:trunkfrom
aaronrobertshaw:add/text-indent-support
Closed

Block Supports: Add text indent to typography supports #10573
aaronrobertshaw wants to merge 4 commits intoWordPress:trunkfrom
aaronrobertshaw:add/text-indent-support

Conversation

@aaronrobertshaw
Copy link

@aaronrobertshaw aaronrobertshaw commented Dec 1, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/64326#ticket

Description

Adds support for text-indent styles for Typography block supports.

WordPress/gutenberg#74889

Test Instructions

  1. Adopt typography.textIndent block support for a dynamic block via its block.json file
  2. Add a typography.textIndent value for the chosen test block in your theme.json file
  3. Create a post with the test block type
  4. Confirm the global style is applied to your test block

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@aaronrobertshaw aaronrobertshaw force-pushed the add/text-indent-support branch 2 times, most recently from 6a0938c to 6beebe3 Compare January 30, 2026 07:40
@aaronrobertshaw aaronrobertshaw marked this pull request as ready for review February 12, 2026 01:27
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, ramonopoly, andrewserong.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd
Copy link
Member

ramonjd commented Feb 12, 2026

This works as described and matches the diff between WordPress/gutenberg#74889

I'm just wondering whether we need to add test coverage for the new support and its expected output.

@andrewserong
Copy link
Contributor

+1 this is testing nicely for me, too, should be good once it's got a couple tests, I think.

@aaronrobertshaw
Copy link
Author

I've added some tests to cover both the block support and global styles angles. Let me know if they hit the spot.

@ramonjd
Copy link
Member

ramonjd commented Feb 12, 2026

I've added some tests to cover both the block support and global styles angles. Let me know if they hit the spot.

LGTM. I'll rebase quickly to fix conflicts

@ramonjd ramonjd force-pushed the add/text-indent-support branch from 96aadb3 to 30fe929 Compare February 12, 2026 09:48
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and adding tests, LGTM too! 🚀

@ramonjd ramonjd force-pushed the add/text-indent-support branch from 30fe929 to 5968659 Compare February 13, 2026 00:35
@ramonjd ramonjd force-pushed the add/text-indent-support branch from 5968659 to 283358d Compare February 13, 2026 01:04
@ramonjd
Copy link
Member

ramonjd commented Feb 13, 2026

Committed in r61632 and d082b28

@ramonjd ramonjd closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants