Block Supports: Add text indent to typography supports #10573
Block Supports: Add text indent to typography supports #10573aaronrobertshaw wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
6a0938c to
6beebe3
Compare
6beebe3 to
a31c975
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This works as described and matches the diff between WordPress/gutenberg#74889 I'm just wondering whether we need to add test coverage for the new support and its expected output. |
|
+1 this is testing nicely for me, too, should be good once it's got a couple tests, I think. |
|
I've added some tests to cover both the block support and global styles angles. Let me know if they hit the spot. |
LGTM. I'll rebase quickly to fix conflicts |
96aadb3 to
30fe929
Compare
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for the updates and adding tests, LGTM too! 🚀
30fe929 to
5968659
Compare
5968659 to
283358d
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/64326#ticket
Description
Adds support for
text-indentstyles for Typography block supports.WordPress/gutenberg#74889
Test Instructions
typography.textIndentblock support for a dynamic block via its block.json filetypography.textIndentvalue for the chosen test block in your theme.json fileThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.